From: Jeff King <peff@peff.net>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH 2/4] Move pack_refs() and friends into libgit
Date: Sun, 15 Jun 2008 13:52:00 -0400 [thread overview]
Message-ID: <20080615175159.GA6127@sigill.intra.peff.net> (raw)
In-Reply-To: <200806151605.07008.johan@herland.net>
On Sun, Jun 15, 2008 at 04:05:06PM +0200, Johan Herland wrote:
> ---
> Makefile | 2 +
> builtin-pack-refs.c | 121 +-----------------------------------------------
> pack-refs.c | 117 ++++++++++++++++++++++++++++++++++++++++++++++
> pack-refs.h | 18 ++++++++
> 4 files changed, 138 insertions(+), 120 deletions(-)
> create mode 100644 pack-refs.c
> create mode 100644 pack-refs.h
This patch would have been a lot easier to read, btw, if it had been
generated with '-C' (then patch to pack-refs.c is based on
builtin-pack-refs instead of /dev/null).
-Peff
next prev parent reply other threads:[~2008-06-15 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 14:02 [PATCH 0/4] Teach "git clone" to pack refs Johan Herland
2008-06-15 14:04 ` [PATCH 1/4] Incorporate fetched packs in future object traversal Johan Herland
2008-06-15 14:05 ` [PATCH 2/4] Move pack_refs() and friends into libgit Johan Herland
2008-06-15 17:52 ` Jeff King [this message]
2008-06-15 21:27 ` [PATCH 2/4 v2] " Johan Herland
2008-06-15 14:05 ` [PATCH 3/4] Prepare testsuite for a "git clone" that packs refs Johan Herland
2008-06-15 17:54 ` Jeff King
2008-06-15 18:04 ` Jakub Narebski
2008-06-15 23:16 ` [PATCH 3/4 v2] " Johan Herland
2008-06-15 14:06 ` [PATCH 4/4] Teach "git clone" to pack refs Johan Herland
2008-06-15 17:56 ` Jeff King
2008-06-15 22:03 ` Johan Herland
2008-06-16 9:57 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2008-03-22 1:10 [RFC/PATCH 0/3] Teach builtin-clone " Johan Herland
2008-04-14 6:10 ` [RFC/PATCH 2/3] Prepare testsuite for a "git clone" that packs refs Daniel Barkalow
2008-04-14 8:00 ` Johan Herland
2008-04-14 8:02 ` [PATCH 2/4] Move pack_refs() and friends into libgit Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080615175159.GA6127@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).