From: Ingo Molnar <mingo@elte.hu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git-rerere observations and feature suggestions
Date: Mon, 16 Jun 2008 21:09:11 +0200 [thread overview]
Message-ID: <20080616190911.GA7047@elte.hu> (raw)
In-Reply-To: <7vej6xb4lr.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> wrote:
> > - Automation: would be nice to have a git-rerere modus operandi where
> > it would auto-commit things if and only if all conflicting files were
> > resolved.
>
> I am not sure how safe this is. rerere as originally designed does
> not even update the index with merge results so that the application
> of earlier resolution can be manually inspected, and this is exactly
> because I consider a blind textual reapplication of previous
> resolution always iffy, even though I invented the whole mechanism.
We use a 'safe, lazy integration' method in -tip, that basically has
external checks against any integration bugs.
Basically, we integrate only about once a day, and we advance the topic
branches but do not reintegrate on every topic merge. We merge commits
_both_ to their target topic branches, and to the (previous) integration
branch.
Then once a day (or every second day) we 'reintegrate': we propagate the
topic branches to the linux-next auto-*-next branches [recreating them
from scratch] and flush out the messy criss-cross merges from the
integration tree.
But that is always an identity transformation as far as the integration
result is concerned: the result of the integration run must be exactly
the same content (obviously it results in a very different tree
structure) as the previous one. We only run it on a perfectly tested
tree so we know none of our previous merges were wrong, and we want the
git-rerere result to be the same. We repeat the integration until the
end result matches.
In fact sometimes git-rerere is able to pick up a conflict resolution
from our 'messy' delta-merge into the integration tree, which is an
added bonus. (this doesnt always work if the merge order differs from
integration order)
Anyway, the gist is that in this workflow it does not hurt at all if
git-rerere is "unsafe", and we'd love to have the integration as fast as
possible. Right now most of my manual overhead is in making sure that
git-rerere has not missed some file.
At a ~100 conflicting files tracked, that is rather error-prone, and i'd
love to have further automation here besides a rather lame method of
grepping for:
"Resolved 'kernel/Makefile' using previous resolution."
type of patterns in git-merge output.
So i'd not mind if git-rerere was safe by default, but it would be nice
to have some knob to turn it into something fast and automatic. For us
it would be much _safer_, because right now most of our manual energy is
spent on checking something that could be automated.
We could in theory avoid git-rerere altogether by creating separate
conflict resolution branches, and automated their handling - but we
thought git-rerere was pretty nice as well and kept the branch count
down.
And while asking for an arm i'd also like to ask for a leg, if i may:
i'd love it if a "slightly conflicting" octopus merge of 85 topic trees
would not result in one huge conflict commit that merges together 1000
commits into a single commit ;-)
So right now in our -tip scripts work around this issue: we 'serialize'
the topic merges despite having very nice opportunities for higher-order
octopus merges. The integration would be a lot faster if we could use
octopus merges and automated git-rerere. (Octopus merges would look much
nicer as well in graphical representation as well, which counts too :-) )
Ingo
next prev parent reply other threads:[~2008-06-16 19:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 11:01 git-rerere observations and feature suggestions Ingo Molnar
2008-06-16 11:09 ` Mike Hommey
2008-06-16 15:48 ` Pierre Habouzit
2008-06-16 15:57 ` Pierre Habouzit
2008-06-16 16:18 ` Sverre Rabbelier
2008-06-17 7:37 ` Karl Hasselström
2008-06-16 11:26 ` David Kastrup
2008-06-16 11:27 ` Theodore Tso
2008-06-16 12:38 ` David Kastrup
2008-06-16 19:52 ` Ingo Molnar
2008-06-16 20:25 ` Junio C Hamano
2008-06-16 20:46 ` Ingo Molnar
2008-06-16 21:37 ` Junio C Hamano
2008-06-16 18:46 ` Junio C Hamano
2008-06-16 19:09 ` Ingo Molnar [this message]
2008-06-16 20:50 ` Junio C Hamano
2008-06-22 9:47 ` [PATCH 1/5] rerere: rerere_created_at() and has_resolution() abstraction Junio C Hamano
2008-06-22 9:47 ` [PATCH 2/5] git-rerere: detect unparsable conflicts Junio C Hamano
2008-06-22 9:47 ` [PATCH 3/5] rerere: remove dubious "tail_optimization" Junio C Hamano
2008-06-22 9:48 ` [PATCH 4/5] t4200: fix rerere test Junio C Hamano
2008-06-22 9:48 ` [PATCH 5/5] rerere.autoupdate Junio C Hamano
2008-06-18 10:57 ` git-rerere observations and feature suggestions Ingo Molnar
2008-06-18 11:29 ` Miklos Vajna
2008-06-18 18:43 ` Ingo Molnar
2008-06-18 19:53 ` Miklos Vajna
2008-06-18 11:36 ` Ingo Molnar
2008-06-18 22:01 ` Jakub Narebski
2008-06-18 22:38 ` Miklos Vajna
2008-06-19 7:23 ` Karl Hasselström
2008-06-19 7:29 ` Miklos Vajna
2008-06-19 7:30 ` Junio C Hamano
2008-06-19 8:21 ` Karl Hasselström
2008-06-19 8:33 ` Miklos Vajna
2008-06-19 9:19 ` Karl Hasselström
2008-06-19 10:06 ` Miklos Vajna
2008-06-19 10:35 ` Karl Hasselström
2008-06-16 19:10 ` Junio C Hamano
2008-06-16 19:44 ` Ingo Molnar
2008-06-23 9:49 ` Ingo Molnar
2008-06-23 14:19 ` Peter Zijlstra
2008-06-23 14:26 ` Peter Zijlstra
2008-06-23 15:12 ` Jeff King
2008-06-23 15:22 ` Ingo Molnar
2008-06-16 20:11 ` Jakub Narebski
2008-06-17 10:24 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616190911.GA7047@elte.hu \
--to=mingo@elte.hu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).