git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-apply doesn't handle same name patches well [V2]
Date: Tue, 17 Jun 2008 10:14:52 -0400	[thread overview]
Message-ID: <20080617141452.GJ16941@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0806171027200.6439@racer>

On Tue, Jun 17, 2008 at 10:30:35AM +0100, Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 16 Jun 2008, Don Zickus wrote:
> 
> > Changes since v1
> > ================
> > - converted to path-list structs
> > - added testcases for renaming a patch and apply a new patch on top inside
> > the same patch file
> 
> Just for future reference: commonly, this is not put into the commit 
> message, but after the "---" separator into the mail comments.

Ok. Thanks.

> 
> > +/*
> > + * Caches patch filenames to handle the case where a
> > + * patch chunk reuses a filename
> > + */
> > +struct fn_cache {
> > +	char *name;
> > +	struct patch *patch;
> > +	struct fn_cache *next;
> > +};
> 
> It is still not a path_list.  Even if you said so in the "Changes since 
> V1".

Yeah, I attached the wrong patch, see V3. :-)

Cheers,
Don

      reply	other threads:[~2008-06-17 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 16:24 [PATCH] git-apply doesn't handle same name patches well [V2] Don Zickus
2008-06-17  9:30 ` Johannes Schindelin
2008-06-17 14:14   ` Don Zickus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080617141452.GJ16941@redhat.com \
    --to=dzickus@redhat.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).