From: Mike Hommey <mh@glandium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: 'setup_work_tree()' considered harmful
Date: Wed, 18 Jun 2008 11:05:27 +0200 [thread overview]
Message-ID: <20080618090527.GA24254@glandium.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0806161723081.2949@woody.linux-foundation.org>
On Mon, Jun 16, 2008 at 05:45:25PM -0700, Linus Torvalds wrote:
> ie note how it does one unnecessary "open()" less, but more importantly,
> notice the difference between "/home/torvalds/kernel/.git/*" and ".git/*",
> and realize that that second difference was the much more noticeable one.
>
> And no, obviously the right fix is not to just comment out all of
> "setup_work_tree()" (it will break stuff that depends on GIT_WORKTREE),
> but I did that as a minimal example of showing what the bad effect of that
> function is.
>
> In general, I think we've gone in the wrong direction with a lot of the
> "make_absolute_path" stuff. See above. 5% performance loss is not good.
Maybe using openat, fstatat, etc. when they are available, could be a
good thing, already, though it wouldn't help for other platforms.
Mike
next prev parent reply other threads:[~2008-06-18 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 0:45 'setup_work_tree()' considered harmful Linus Torvalds
2008-06-17 0:52 ` Linus Torvalds
2008-06-17 11:01 ` Johannes Schindelin
2008-06-18 9:05 ` Mike Hommey [this message]
2008-06-18 16:26 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618090527.GA24254@glandium.org \
--to=mh@glandium.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).