From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Florian Köberle" <FloriansKarten@web.de>
Cc: git@vger.kernel.org, galder.zamarreno@redhat.com,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [JGIT] fnmatch Implementation.
Date: Wed, 18 Jun 2008 20:43:42 +0200 [thread overview]
Message-ID: <200806182043.43321.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <4858DFA2.30203@web.de>
onsdagen den 18 juni 2008 12.12.50 skrev Florian Köberle:
> Hi,
>
> when I send a large list of patches and one is wrong then you don't
> accept any. That's why I now will try to get one patch in before I send
> the next one.
Patience please. When there is long series it *will* take time for
a number of reasons. Most have nothing to do with this project at all. But in
general you will find a short patch series *much* easier to get through than
a long one.
If you think my grouping is ok, then ack and I can commit from there. I
was thinking of actually adding some test myself, but that's all I had in mind.
> The first patch I will commit this way is the fnmatch patch.
>
> As suggested by Robin I replaced unicode characters not included in the
> ASCII set with \uXXXX sequences.
>
> I also added some more test cases and improved the javadoc of the
> FileNameMatcher class.
That's good.
>
> Best regards,
> Florian
>
prev parent reply other threads:[~2008-06-18 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 10:12 [JGIT] fnmatch Implementation Florian Köberle
2008-06-18 18:43 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806182043.43321.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=FloriansKarten@web.de \
--cc=galder.zamarreno@redhat.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).