Re: [egit-jgit] excluded patterns are decorated as being untracked

[Robin Rosenberg <robin.rosenberg.lists@dewire.com>]

onsdagen den 18 juni 2008 17.40.56 skrev Galder Zamarreno:
> Hmmmm, is marking a resource as "derived" recursive? i.e. if I mark 
> "output" folder as derived, would anything under it be considered 
> derived? It'd be a pain to go a mark as derived each and every class.

It seems it is not recursive and worse, not saved with the project.

> I suppose you still need the patch to use Team.isIgnoredHint to get 
> derived resources to be ignored, correct?

You'll need another patch for the decorator to pick up derived resources
properly. Probably not the final solution to decorations. For one thing the
decorators are horribly inefficient.

> Hmmmm, so the proper way is either marking resources as derived and use 
> your patch or implementing .git/info/exclude, correct?

I'd say implementing .git/info/exlude is the proper solution. The others are
mere workarounds.

-- robin

>From 7acc0e63886ed8eda6b38a5edbfe9a6aa4d509dc Mon Sep 17 00:00:00 2001
From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Wed, 18 Jun 2008 23:50:42 +0200
Subject: [PATCH] Decorate derived resources as ignored.

This is done by using the appropriate API.

Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
 .../internal/decorators/GitResourceDecorator.java  |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
index 4b6394c..0308f6a 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
@@ -273,8 +273,7 @@ public class GitResourceDecorator extends LabelProvider implements
 							}
 
 						} else {
-							if (rsrc.getType() == IResource.FILE
-									&& Team.isIgnored((IFile) rsrc)) {
+							if (Team.isIgnoredHint(rsrc)) {
 								decoration.addSuffix("(ignored)");
 							} else {
 								decoration.addPrefix(">");
-- 
1.5.5.1.178.g1f811