git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Dan McGee <dpmcgee@gmail.com>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] completion: add --graph to log command completion
Date: Fri, 20 Jun 2008 01:40:12 +0300	[thread overview]
Message-ID: <20080619224012.GA6705@mithlond.arda.local> (raw)
In-Reply-To: <20080619215842.GL11793@spearce.org>

Shawn O. Pearce wrote (2008-06-19 17:58 -0400):

> Dan McGee <dpmcgee@gmail.com> wrote:
> > Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> 
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
> 
> First change for 1.5.6.1?  With --graph in 1.5.6 we really should have
> included this as part of 1.5.6.  Oh well.  1.5.6.1 perhaps Junio?

Liked-by: me

I think I have already sent twice a patch with --graph completion. I use
bash completions quite a lot and here's my current additions to "git
log":


---snip---
bash: Add more option completions for 'git log'

Options added: --graph --walk-reflogs --stat --numstat --shortstat
--decorate --diff-filter= --color-words

Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
---
 contrib/completion/git-completion.bash |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 506b40c..e78ca8e 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -761,6 +761,9 @@ _git_log ()
 			--pretty= --name-status --name-only --raw
 			--not --all
 			--left-right --cherry-pick
+			--stat --numstat --shortstat
+			--decorate --diff-filter=
+			--color-words --walk-reflogs --graph
 			"
 		return
 		;;
-- 
1.5.6.2.g3c3a

  reply	other threads:[~2008-06-19 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19 21:15 [PATCH] completion: add --graph to log command completion Dan McGee
2008-06-19 21:58 ` Shawn O. Pearce
2008-06-19 22:40   ` Teemu Likonen [this message]
2008-06-19 22:55     ` Shawn O. Pearce
2008-06-19 23:06       ` Dan McGee
2008-06-20  6:31       ` Teemu Likonen
2008-06-20 13:02         ` [PATCH v2] bash: Add more option completions for 'git log' Teemu Likonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080619224012.GA6705@mithlond.arda.local \
    --to=tlikonen@iki.fi \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).