From: Stephan Beyer <s-beyer@gmx.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/2] t3404: extra checks and s/! git/test_must_fail git/
Date: Fri, 20 Jun 2008 21:00:37 +0200 [thread overview]
Message-ID: <20080620190037.GE7369@leksak.fem-net> (raw)
In-Reply-To: <X-0hXtX7hZGzbL_zS7e4VUMsiMfWiIfABUCFp28XZx0@cipher.nrlssc.navy.mil>
Hi,
> > @@ -380,7 +397,7 @@ test_expect_success 'interrupted squash works as expected' '
> > ! FAKE_LINES="1 squash 3 2" git rebase -i HEAD~3 &&
>
> These can be converted to use test_must_fail by using a sub-shell
> as Junio demonstrated:
>
> (
> FAKE_LINES="1 squash 3 2" &&
> export FAKE_LINES &&
> test_must_fail git rebase -i HEAD~3
> ) &&
Perhaps I'm not consequent, but I thought that it's not worth it ;-)
(There is also another reason: I use a dirty test-lib.sh _hack_ locally,
that allows me to exactly see where a failing test_expect_success patch
fails (that saves some time), but the hack does not work on tests with a
subshell invocation.)
Regards,
Stephan
--
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
next prev parent reply other threads:[~2008-06-20 19:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 2:45 some small changes for rebase-i Stephan Beyer
2008-06-20 2:45 ` [PATCH 1/3] t3404: slight improvements Stephan Beyer
2008-06-20 2:45 ` [PATCH 2/3] rebase-i: slight internal improvements Stephan Beyer
2008-06-20 2:45 ` [PATCH 3/3] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 5:48 ` Stephan Beyer
2008-06-20 13:15 ` Johannes Schindelin
2008-06-20 18:30 ` [PATCH 1/2] t3404: extra checks and s/! git/test_must_fail git/ Stephan Beyer
2008-06-20 18:30 ` [PATCH 2/2] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 18:48 ` [PATCH 1/2] t3404: extra checks and s/! git/test_must_fail git/ Brandon Casey
2008-06-20 19:00 ` Stephan Beyer [this message]
2008-06-20 22:18 ` しらいしななこ
2008-06-21 1:46 ` Stephan Beyer
2008-06-21 9:46 ` Junio C Hamano
2008-06-21 23:55 ` [PATCH v3 1/2] t3404: stricter tests for git-rebase--interactive Stephan Beyer
2008-06-21 23:55 ` [PATCH v3 2/2] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 7:16 ` [PATCH 2/3] rebase-i: slight internal improvements Johannes Sixt
2008-06-20 8:01 ` Stephan Beyer
2008-06-20 8:17 ` Johannes Sixt
2008-06-20 12:46 ` Johannes Schindelin
2008-06-20 18:45 ` Stephan Beyer
2008-06-20 13:05 ` [PATCH 1/3] t3404: slight improvements Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620190037.GE7369@leksak.fem-net \
--to=s-beyer@gmx.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=casey@nrlssc.navy.mil \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).