Re: [jgit PATCH] Paper bag fix quoting for SSH transport commands

["Shawn O. Pearce" <spearce@spearce.org>]

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> söndagen den 22 juni 2008 03.36.40 skrev Shawn O. Pearce:
> > 
> > Testing concludes that git-shell requires the command name to never
> > be quoted, and the argument name to always be single quoted.  As
> > this is a long-standing behavior in the wild jgit needs to conform,
> > as git-shell and all git-shell work-a-likes such as gitosis may be
> > following the same convention.
> 
> Seems ok and works here. Error handling still has a paperbagish feel. See
> follow up patches.

Well, I wasn't trying to clean up error handling, I was just trying
to make `jgit fetch` work against repo.or.cz.  But I agree, the
error handling and feedback in the transport code could be improved.

> Maybe we should have a patch for git too so it will actually work
> with spaces in file names. What do people on Windows do? (those that
> actually get an SSH server up and running and sleep well overe it
> on that platform).

The issue only happens with the command name, which most people
use just git-upload-pack/git-receive-pack as they have git in their
$PATH on the remote side, or are running git-shell.  I suspect that
Windows users just don't run Git over SSH with paths that contain
spaces to access git-upload-pack remotely.

I'd patch Git to use the same rule as jgit and only quote the command
when really necessary, but its not high on my list of things to do
this month.  :-)

> As for pushing and signing. One way is for you (Shawn) and me is
> to sign-off and push each other's patches. I pushed this one.

Given that repo.or.cz doesn't show reflogs, I take it this is only
a way to make sure at least someone has reviewed the patch before
it goes into the main tree, since we both have write access?  I
can live with that.

-- 
Shawn.