Git development
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] implement some resilience against pack corruptions
Date: Mon, 23 Jun 2008 21:33:31 -0400	[thread overview]
Message-ID: <20080624013331.GR11793@spearce.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0806232122180.2979@xanadu.home>

Nicolas Pitre <nico@cam.org> wrote:
> We should be able to fall back to loose objects or alternative packs when
> a pack becomes corrupted.  This is especially true when an object exists
> in one pack only as a delta but its base object is corrupted.  Currently
> there is no way to retrieve the former object even if the later is
> available in another pack or loose.

Dang, nice timing Nico.  We were bitten by something like this at
day-job a couple of weeks back.  Adding this sort of support went
onto my internal todo-list.  I'm glad you beat me to it.  :)
 
> Yes I've been bitten by the corruption described above...

But sorry to hear about this.

As usual for your patches, the implementation looks quite sane.
Thanks for taking care of it.
 
-- 
Shawn.

  reply	other threads:[~2008-06-24  1:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24  1:23 [PATCH 2/3] implement some resilience against pack corruptions Nicolas Pitre
2008-06-24  1:33 ` Shawn O. Pearce [this message]
2008-06-24  2:20   ` Nicolas Pitre
2008-06-24  4:49 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080624013331.GR11793@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox