Code Formatting vs Trailing Whitespaces

Code Formatting vs Trailing Whitespaces

[Florian Köberle]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

I noticed that Robin removed trailing whitespaces from my patch(thanks).
It appears that if you enable code formatting and the removement of
trailing whitespaces in the save actions option that the formatting
option will win.
It will add a space at the second line of a javadoc comment:
/**
~ * <----

I think this is a bug in eclipse, did any of you create a bug report for
that? Or a feature request for an "no whitespace after javadoc" option
in the code formatter page?

I want to have both options active, because I don't want to commit wrong
formatted patches.

Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIX+hW59ca4mzhfxMRApU4AKCbYzwRFqVcBCr11zc9lk6jqick2ACeMBhW
nXOoN4nIsTjzWWhQzDOxiz4=
=bm+i
-----END PGP SIGNATURE-----

Re: Code Formatting vs Trailing Whitespaces

[Robin Rosenberg]

måndagen den 23 juni 2008 20.15.50 skrev Florian Köberle:
> Hi
> 
> I noticed that Robin removed trailing whitespaces from my patch(thanks).
> It appears that if you enable code formatting and the removement of
> trailing whitespaces in the save actions option that the formatting
> option will win.
> It will add a space at the second line of a javadoc comment:
> /**
> ~ * <----
> 
> I think this is a bug in eclipse, did any of you create a bug report for
> that? Or a feature request for an "no whitespace after javadoc" option
> in the code formatter page?

This one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619

> I want to have both options active, because I don't want to commit wrong
> formatted patches.

When I have both options active, it adds the whitespace when formatting, but
removes it when saving in (version 3.3.2).

-- robin

Re: Code Formatting vs Trailing Whitespaces

[Florian Köberle]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

| This one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619
Thank you. I voted for that feature, maybe it helps to draw attention to
this feature wish.

| When I have both options active, it adds the whitespace when
formatting, but
| removes it when saving in (version 3.3.2).
Strange, I use version 3.3.2 too. I configured it in the workspace settings.
Maybe you did in the project settings?

Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIYBLy59ca4mzhfxMRAs7vAJ4la1ABhh5Q6pwvhGdx9bZHJvQvWwCfS8nr
2oakNrgbvGSVlGkLzwlJYbw=
=rZFh
-----END PGP SIGNATURE-----

Re: Code Formatting vs Trailing Whitespaces

[Robin Rosenberg]

måndagen den 23 juni 2008 23.17.38 skrev Florian Köberle:
> Hi
> 
> | This one matches: https://bugs.eclipse.org/bugs/show_bug.cgi?id=49619
> Thank you. I voted for that feature, maybe it helps to draw attention to
> this feature wish.
> 
> | When I have both options active, it adds the whitespace when
> formatting, but
> | removes it when saving in (version 3.3.2).
> Strange, I use version 3.3.2 too. I configured it in the workspace settings.
> Maybe you did in the project settings?

Indeed.

-- robin