From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
Daniel Barkalow <barkalow@iabervon.org>,
zuh@iki.fi, git@vger.kernel.org
Subject: Re: [PATCH] clone: create intermediate directories of destination repo
Date: Tue, 24 Jun 2008 04:04:38 -0400 [thread overview]
Message-ID: <20080624080437.GA2581@sigill.intra.peff.net> (raw)
In-Reply-To: <7v3an3e0xv.fsf@gitster.siamese.dyndns.org>
On Tue, Jun 24, 2008 at 12:39:40AM -0700, Junio C Hamano wrote:
> > The shell version used to use "mkdir -p" to create the repo path, but
> > the C version just calls "mkdir". Let's replicate the old behavior. In
> > this case we can simply create the directories leading up to the git
> > dir. If it's a bare repo, then that is everything that init_db wants
> > ahead of time. If it isn't bare, then the worktree contains the git dir,
> > so we create the worktree.
>
> Clever ;-)
I am worried that it is too clever. I didn't see an obvious way for
work_tree and git_dir to not have that property, but I think it is still
worth somebody double-checking.
-Peff
next prev parent reply other threads:[~2008-06-24 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 19:51 Git clone behaviour change in 1.5.6 (vs 1.5.5.1) Kalle Vahlman
2008-06-23 19:56 ` Daniel Barkalow
2008-06-23 20:38 ` Jeff King
2008-06-23 21:03 ` Brandon Casey
2008-06-24 5:50 ` [PATCH] clone: create intermediate directories of destination repo Jeff King
2008-06-24 7:39 ` Junio C Hamano
2008-06-24 8:04 ` Jeff King [this message]
2008-06-24 15:20 ` Daniel Barkalow
2008-06-25 5:41 ` Jeff King
2008-06-25 6:11 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624080437.GA2581@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zuh@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox