From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Holtje <docwhat@gmail.com>,
Alex Riesen <raa.lkml@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] pre-commit hook should ignore carriage returns at EOL
Date: Fri, 27 Jun 2008 00:24:46 -0400 [thread overview]
Message-ID: <20080627042446.GD7144@sigill.intra.peff.net> (raw)
In-Reply-To: <7vlk0rokxb.fsf@gitster.siamese.dyndns.org>
On Thu, Jun 26, 2008 at 04:06:56PM -0700, Junio C Hamano wrote:
> +if git-rev-parse --verify HEAD 2>/dev/null
> +then
> + against=
> +else
> + # Initial commit: diff against an empty tree object
> + against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
> +fi
Heh, I am happy that the virtual empty tree object is coming in handy
again.
>From quick review, the series looks good to me (and it was, btw, very
easy to read -- I think that you, as somebody who reviews a lot of
patches, have gotten very good at splitting up your own sensibly. :) ).
-Peff
prev parent reply other threads:[~2008-06-27 4:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 19:21 [PATCH v2] pre-commit hook should ignore carriage returns at EOL Christian Holtje
2008-06-25 18:14 ` Alex Riesen
2008-06-25 18:47 ` Christian Holtje
2008-06-25 19:14 ` Junio C Hamano
2008-06-26 2:41 ` Christian Holtje
2008-06-26 22:33 ` Junio C Hamano
2008-06-26 22:34 ` [PATCH 1/5] diff --check: explain why we do not care whether old side is binary Junio C Hamano
2008-06-26 22:35 ` [PATCH 2/5] check_and_emit_line(): rename and refactor Junio C Hamano
2008-06-26 22:36 ` [PATCH 3/5] checkdiff: pass diff_options to the callback Junio C Hamano
2008-06-26 22:36 ` [PATCH 4/5] Teach "diff --check" about a new blank lines at end Junio C Hamano
2008-06-26 22:37 ` [PATCH 5/5] diff --check: detect leftover conflict markers Junio C Hamano
2008-06-26 23:01 ` [PATCH v2] pre-commit hook should ignore carriage returns at EOL Junio C Hamano
2008-06-26 23:06 ` Junio C Hamano
2008-06-27 4:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627042446.GD7144@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=docwhat@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).