Git development
 help / color / mirror / Atom feed
From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Robert Anderson <rwa000@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: An alternate model for preparing partial commits
Date: Fri, 27 Jun 2008 19:27:01 +0200	[thread overview]
Message-ID: <20080627172701.GB15359@atjola.homenet> (raw)
In-Reply-To: <9af502e50806270954q613087efub0eb05c25f2eefb9@mail.gmail.com>

On 2008.06.27 09:54:43 -0700, Robert Anderson wrote:
> On Fri, Jun 27, 2008 at 12:10 AM, Björn Steinbrink <B.Steinbrink@gmx.de> wrote:
> > Hm, I use "stash" for that purpose, which leads to kind of the reverse
> > of your approach. So I do sth. like this:
> >  - hack hack hack
> >  - Notice that I want to make two commits out of what I have in my
> >   working tree
> >  - git add -p -- stage what I want in the first commit
> >  - git commit -m tmp -- temporary commit
> 
> This is a guess at the first commit?  I don't like it, but I'm still
> listening.

It's rather a work-around to stash away only the changes that are not in
the index. See the other reply to my mail for a patch that adds an
option to stash to do that without the commit/reset hack.

> >  - git stash -- stash away what doesn't belong in the first commit
> >  - git reset HEAD^ -- drop the temporary commit, with the changes kept
> >   in the working tree
> 
> Now I have my guess at the first commit as my tree state, correct?
> What happens when I decide I need a couple of hunks from another file
> which I missed in my first guess, and is now in the stashed state?
> How do I get those out of the stash and into the working tree?  If
> there is no convenient way to do that, then this method is not
> sufficient to cover the use case I am talking about.

git stash pop
eventually fix conflicts if you changed the working tree in the meantime
go back to the "git add -p" step

Björn

  reply	other threads:[~2008-06-27 17:28 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <willow-jeske-01l7H4tHFEDjCgPV-01l7H4sOFEDjCbyi>
2008-06-27  6:50 ` An alternate model for preparing partial commits Robert Anderson
2008-06-27  7:10   ` Björn Steinbrink
2008-06-27 14:37     ` [PATCH/RFC] stash: introduce 'stash save --keep-index' option SZEDER Gábor
2008-06-27 18:26       ` Junio C Hamano
2008-06-27 16:54     ` An alternate model for preparing partial commits Robert Anderson
2008-06-27 17:27       ` Björn Steinbrink [this message]
2008-06-27 17:34         ` Robert Anderson
2008-06-27  8:35   ` Johannes Sixt
2008-06-27 17:01     ` Robert Anderson
2008-06-27  8:50   ` Petr Baudis
2008-06-27 17:02     ` Robert Anderson
2008-06-27 13:33   ` Johannes Schindelin
2008-06-27 13:49     ` Miklos Vajna
2008-06-27 17:14     ` Robert Anderson
2008-06-27 17:45       ` Johannes Schindelin
2008-06-27 17:49         ` Robert Anderson
     [not found]           ` <alpine.DEB.1.00.0806271854120.9925@racer>
2008-06-27 18:07             ` Robert Anderson
2008-06-27 18:20           ` Dana How
2008-06-27 20:31       ` Stephen Sinclair
2008-06-27 20:45         ` David Jeske
2008-06-28 17:23           ` Wincent Colaiuta
2008-06-27 20:45         ` David Jeske
2008-06-28  2:14       ` Dmitry Potapov
2008-06-28  2:57         ` Robert Anderson
2008-06-28  4:03           ` Dmitry Potapov
     [not found]             ` <9af502e50806272320p23f01e8eo4a67c5f6f4476098@mail.gmail.com>
2008-06-28  6:31               ` Fwd: " Robert Anderson
2008-06-28 12:38                 ` Dmitry Potapov
     [not found]               ` <20080628123522.GL5737@dpotapov.dyndns.org>
2008-06-28 15:53                 ` Robert Anderson
2008-06-28 16:52                   ` Dmitry Potapov
2008-06-27 18:15     ` Junio C Hamano
2008-06-27 18:43       ` Robert Anderson
2008-06-28  5:03       ` Jeff King
2008-06-28  7:03         ` Robert Anderson
2008-06-28  8:53           ` Jeff King
2008-06-28 21:53             ` Junio C Hamano
2008-06-28 14:51         ` Johannes Schindelin
2008-07-08  4:58           ` Jeff King
2008-06-27 20:29   ` David Jeske
2008-06-27 20:29   ` David Jeske
2008-06-27 20:47     ` Jakub Narebski
2008-06-27 20:51       ` David Jeske
2008-06-27 20:51       ` David Jeske
     [not found]       ` <-8386235276716376372@unknownmsgid>
2008-06-27 22:55         ` Robert Anderson
2008-06-27 23:14           ` Junio C Hamano
2008-06-28  0:08             ` Robert Anderson
2008-06-28  2:57               ` Dmitry Potapov
2008-06-28  3:31                 ` Robert Anderson
2008-06-28 14:34               ` Stephen Sinclair
2008-06-28 16:00                 ` Robert Anderson
2008-06-28 16:30                 ` Robert Anderson
2008-06-28 17:12                   ` Jakub Narebski
2008-06-28 18:25                     ` Robert Anderson
2008-06-28 19:12                       ` David Jeske
2008-06-28 19:12                       ` David Jeske
2008-06-28 19:13                   ` Stephen Sinclair
2008-06-28  0:22           ` David Jeske
2008-06-28  0:22           ` David Jeske
2008-06-28  1:17 Theodore Tso
2008-06-28  1:56 ` Miklos Vajna
  -- strict thread matches above, loose matches on Subject: below --
2008-06-28  1:23 Theodore Tso
2008-06-28  9:30 Stephen R. van den Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080627172701.GB15359@atjola.homenet \
    --to=b.steinbrink@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=rwa000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox