From: "Fernando J. Pereda" <ferdy@ferdyx.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Skip unwritable tests for root
Date: Mon, 30 Jun 2008 11:27:35 +0200 [thread overview]
Message-ID: <20080630092735.GA10979@ferdyx.org> (raw)
In-Reply-To: <7vabh31e9p.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Mon, Jun 30, 2008 at 02:08:18AM -0700, Junio C Hamano wrote:
> "Fernando J. Pereda" <ferdy@ferdyx.org> writes:
>
> > Signed-off-by: Fernando J. Pereda <ferdy@ferdyx.org>
>
> Hmm. Actually we've deliberately ignored this so far. If we were to do
> anything, don't we rather want to fail everything upfront when the tests
> are run by root?
>
> Running "make" and "make test" before "make install" is so that you have
> less chance hurting your running system, and I find it simply crazy to
> build (i.e. "make all") as root, let alone running tests.
*nod*
This originated because Gentoo can be told to build stuff as root (and
run test as root) under a sandbox. Since I already had the patch
locally, I guessed you might be interested in it and just sent it.
I'll just apply it locally.
- ferdy
[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]
next prev parent reply other threads:[~2008-06-30 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:05 [PATCH] Skip unwritable tests for root Fernando J. Pereda
2008-06-30 7:39 ` Jakub Narebski
2008-06-30 9:08 ` Junio C Hamano
2008-06-30 9:27 ` Fernando J. Pereda [this message]
2008-07-07 19:14 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630092735.GA10979@ferdyx.org \
--to=ferdy@ferdyx.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).