From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Geoff Russell <geoffrey.russell@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: finding deleted file names
Date: Thu, 3 Jul 2008 15:47:28 -0400 [thread overview]
Message-ID: <20080703194728.GA18443@sigill.intra.peff.net> (raw)
In-Reply-To: <7vzloyzrew.fsf@gitster.siamese.dyndns.org>
On Thu, Jul 03, 2008 at 12:41:43PM -0700, Junio C Hamano wrote:
> Once reflog entries begin expiring, we won't have the null_sha1 on the
> previous side of them, and after that we will keep returning the
> oldest-known one, so nobody should be expecting to find out when a ref was
> first created in this repository by checking with what timestamp that
> syntax breaks in the existing interface.
Right, that was my thought: though perhaps not technically as precise,
it is much more DWIM.
My other concern, which I failed to voice in the original mail was:
should we do this magic for other reflog entries besides the first one?
It is possible to end up with a null sha1 in any other entry? Branch
creation shouldn't do it, because we will have deleted any previous
reflog when killing off the branch before, so we always end up putting
in the "oldest" reflog entry. Cloning shouldn't do it for obvious
reasons.
> Sorry for not being Shawn ;-)
Heh.
-Peff
next prev parent reply other threads:[~2008-07-03 19:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 0:01 finding deleted file names Geoff Russell
2008-07-03 1:12 ` Mikael Magnusson
2008-07-03 2:45 ` Geoff Russell
2008-07-03 3:18 ` Mikael Magnusson
2008-07-03 10:42 ` Jeff King
2008-07-04 6:45 ` Geoff Russell
2008-07-04 7:05 ` Junio C Hamano
2008-07-06 4:54 ` Geoff Russell
2008-07-06 5:17 ` Junio C Hamano
2008-07-07 0:41 ` Geoff Russell
2008-07-03 9:20 ` Jakub Narebski
2008-07-03 10:36 ` Jeff King
2008-07-03 19:41 ` Junio C Hamano
2008-07-03 19:47 ` Jeff King [this message]
2008-07-03 20:32 ` Shawn O. Pearce
2008-07-03 11:57 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703194728.GA18443@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=geoffrey.russell@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).