git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Brown <git@davidb.org>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Cherry picking instead of merges.
Date: Thu, 3 Jul 2008 13:53:29 -0700	[thread overview]
Message-ID: <20080703205329.GA17923@old.davidb.org> (raw)
In-Reply-To: <32541b130807031315j3d9b7d77y277e3cb994ab0964@mail.gmail.com>

On Thu, Jul 03, 2008 at 04:15:22PM -0400, Avery Pennarun wrote:

>Unfortunately, since your mismerged branches are already published,
>rewriting history would cause a lot of pain for everyone.  It would be
>better to avoid doing that entirely.  However, I can see why you'd
>want to do that in order to make future git-bisect easier.

It's only sitting in a private developer's branch.  I want to do the merge
properly, but I'm just trying to figure out how to get the conflict
resolution out of his work.

>Basically, if you're going to try to fix the git-bisect intermediate
>versions, you're going to have to rewrite history anyway; in which
>case, why not just make your developer's cherry-picked branch the
>official one?  Then your problems are solved, other than getting all
>your developers onto the new history.

Once we start cherry picking the changes from Company B, we have a
different set of changes from them, and future merges will get harder and
harder.

>This will apply the correct conflict resolution to the tip of your
>newest branch.  All the revisions between X and HEAD will still be
>broken, but that's usually better than trying to rewrite history and
>pretend the broken revisions never existed.  You can always use "git
>bisect skip" for cases like that.

Except we already know that the broken change is inside of the broken
revisions.

It turns out that things are more messed up than I thought.  This developer
had done a 'git push' with some manual refs and pushed what was supposed to
be a merge into an unmerged branch.

I've spoken with all of the developers who use this tree, and everyone
agrees that rewinding the tree is the best way to go.  Now just time to
trudge forward and learn.

But, it makes for a good new rule: no cherry-picking other people's
changes.

David

  reply	other threads:[~2008-07-03 20:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 18:26 Cherry picking instead of merges David Brown
2008-07-03 20:13 ` Alex Riesen
2008-07-03 20:15 ` Avery Pennarun
2008-07-03 20:53   ` David Brown [this message]
2008-07-03 21:18     ` Samuel Tardieu
2008-07-03 21:18 ` Linus Torvalds
2008-07-03 22:39   ` David Brown
2008-07-04  0:10     ` Björn Steinbrink
2008-07-04  4:40       ` David Brown
2008-07-04  5:30         ` Linus Torvalds
2008-07-04  6:36           ` Johannes Sixt
2008-07-04 16:47             ` Linus Torvalds
2008-07-04  0:39     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080703205329.GA17923@old.davidb.org \
    --to=git@davidb.org \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).