git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Brian Hetro <whee@smaertness.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 0/5] git_config_string janitorial conversions.
Date: Sun, 6 Jul 2008 05:47:18 +0200	[thread overview]
Message-ID: <200807060547.19085.chriscool@tuxfamily.org> (raw)
In-Reply-To: <cover.1215234749.git.whee@smaertness.net>

Le samedi 5 juillet 2008, Brian Hetro a écrit :
> These patches are related to the git_config_string "janitorial" work.

Your patches look good to me.

By the way, your first patch in the series seems to fix a bug:

> int git_commit_config(const char *k, const char *v, void *cb)
> {
> -       if (!strcmp(k, "commit.template")) {
> -               if (!v)
> -                       return config_error_nonbool(v);

It should have been:
-                       return config_error_nonbool(k);

> -               template_file = xstrdup(v);
> -               return 0;
> -       }
> +       if (!strcmp(k, "commit.template"))
> +               return git_config_string(&template_file, k, v);

There is the same bug in "wt-status.c". I will send a fix for this one.

So (for the patch series):

Tested-by: Christian Couder <chriscool@tuxfamily.org>

Thanks,
Christian.

      parent reply	other threads:[~2008-07-06  3:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05  5:24 [PATCH 0/5] git_config_string janitorial conversions Brian Hetro
2008-07-05  5:24 ` [PATCH 1/5] builtin-commit.c: Use 'git_config_string' to get 'commit.template' Brian Hetro
2008-07-05  5:24   ` [PATCH 2/5] builtin-log.c: Use 'git_config_string' to get 'format.subjectprefix' and 'format.suffix' Brian Hetro
2008-07-05  5:24     ` [PATCH 3/5] convert.c: Use 'git_config_string' to get 'smudge' and 'clean' Brian Hetro
2008-07-05  5:24       ` [PATCH 4/5] diff.c: Use 'git_config_string' to get 'diff.external' Brian Hetro
2008-07-05  5:24         ` [PATCH 5/5] http.c: Use 'git_config_string' to clean up SSL config Brian Hetro
2008-07-06  3:47 ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807060547.19085.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=whee@smaertness.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).