From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: git-clone --quiet broken?
Date: Mon, 7 Jul 2008 00:56:49 +0200 [thread overview]
Message-ID: <20080706225649.GD17659@steel.home> (raw)
In-Reply-To: <7vmykvrfta.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Sun, Jul 06, 2008 02:56:17 +0200:
> Dave Jones <davej@codemonkey.org.uk> writes:
>
> > The server I run various git snapshots on recently got upgraded to git 1.5.6,
> > ...
> > I could run the clone with 2>/dev/null, but I'd really like to get
> > mail when something breaks instead of it being totally silent.
> >
> > I'm assuming this was an unintentional side-effect of some other recent change?
>
> Yeah, I would assume so, too ;-)
>
> Daniel, is this enough? From re-reading the scripted version of
> git-clone, it appears that we *might* need to squelch no-progress if the
> stdout is not tty; I do not offhand if you got that right when you
> rewrote this in C.
While at it, could we please have the first "Initialize" message
removed?
Initialize git/.git
Initialized empty Git repository in /home/davej/git-trees/git/.git/
The default output looks redundant (that of init_db too, but the full
path can be useful sometimes). Something like this, perhaps:
diff --git a/builtin-clone.c b/builtin-clone.c
index 643c7d4..4a0f1ab 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -421,7 +421,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
die("could not create leading directories of '%s'", git_dir);
set_git_dir(make_absolute_path(git_dir));
- fprintf(stderr, "Initialize %s\n", git_dir);
init_db(option_template, option_quiet ? INIT_DB_QUIET : 0);
/*
next prev parent reply other threads:[~2008-07-06 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 21:16 git-clone --quiet broken? Dave Jones
2008-07-06 0:56 ` Junio C Hamano
2008-07-06 1:22 ` Daniel Barkalow
2008-07-06 22:56 ` Alex Riesen [this message]
2008-07-07 1:40 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080706225649.GD17659@steel.home \
--to=raa.lkml@gmail.com \
--cc=barkalow@iabervon.org \
--cc=davej@codemonkey.org.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox