From: "Stephen R. van den Berg" <srb@cuci.nl>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Brian Foster <brian.foster@innova-card.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] git daemon: avoid calling syslog() from a signal handler
Date: Mon, 7 Jul 2008 08:54:39 +0200 [thread overview]
Message-ID: <20080707065439.GA25877@cuci.nl> (raw)
In-Reply-To: <7vmykua2et.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
>Another thing we might want to consider to make this logic much more
>simpler would be to move everything out of child_handler(), except the
>write() whose sole purpose is to allow us break out of the poll().
As a general rule, keep the work done in a signal handler down to the
bare minimum (like setting an integer flag, and perhaps unblocking the
main thread through a write to this signallingpipe).
--
Sincerely,
Stephen R. van den Berg.
A truly wise man never plays leapfrog with a unicorn.
prev parent reply other threads:[~2008-07-07 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 12:00 Non-inetd git-daemon hangs in syslog(3)/fclose(3) if --syslog --verbose accessing non-repositories Brian Foster
2008-07-03 12:45 ` Johannes Schindelin
2008-07-03 13:52 ` Brian Foster
2008-07-03 14:32 ` Johannes Schindelin
2008-07-03 15:27 ` [PATCH] git daemon: avoid calling syslog() from a signal handler Johannes Schindelin
2008-07-05 7:34 ` Junio C Hamano
2008-07-05 10:05 ` Johannes Schindelin
2008-07-05 17:26 ` Junio C Hamano
2008-07-06 1:42 ` Johannes Schindelin
2008-07-06 6:08 ` Junio C Hamano
2008-07-06 12:23 ` [PATCH v2] " Johannes Schindelin
2008-07-07 1:50 ` Junio C Hamano
2008-07-07 6:54 ` Stephen R. van den Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707065439.GA25877@cuci.nl \
--to=srb@cuci.nl \
--cc=Johannes.Schindelin@gmx.de \
--cc=brian.foster@innova-card.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).