From: Don Zickus <dzickus@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] git-mailinfo may corrupt patch headers on attached files
Date: Mon, 7 Jul 2008 09:39:45 -0400 [thread overview]
Message-ID: <20080707133945.GB23190@redhat.com> (raw)
In-Reply-To: <7v1w269sp9.fsf@gitster.siamese.dyndns.org>
On Sun, Jul 06, 2008 at 10:19:46PM -0700, Junio C Hamano wrote:
> The point you inserted strlen() above, however, is one of the places that
> line[] has patch text and can have NUL in it, so strlen() there would
> break the earlier fix.
>
> Here is the minimum replacement patch, still not handling embedded NULs
> anywhere in the structural part of the message, that should work. Sane
> MUAs should quote embedded NULs in the original contents with QP or BASE64
> to protect them from handle_boundary() and other functions, and after
> decoding, these embedded NULs will be kept by decode_transfer_encoding(),
> so I think this would work Ok in practice.
>
> I tested this with both Linus's test message and it does not break t5100.
Good thing for test cases. :-) Thanks for the explanation.
ACK
Cheers,
Don
prev parent reply other threads:[~2008-07-07 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 17:47 'git am' breakage with MIME decoding Linus Torvalds
2008-07-06 21:21 ` [PATCH] git-mailinfo may corrupt patch headers on attached files Don Zickus
2008-07-06 21:52 ` Linus Torvalds
2008-07-06 22:13 ` Junio C Hamano
2008-07-07 0:09 ` Junio C Hamano
2008-07-07 5:19 ` Junio C Hamano
2008-07-07 13:39 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707133945.GB23190@redhat.com \
--to=dzickus@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).