From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix http-push test
Date: Mon, 7 Jul 2008 22:17:20 +0200 [thread overview]
Message-ID: <20080707201720.GA1356@glandium.org> (raw)
In-Reply-To: <7vej6531xa.fsf@gitster.siamese.dyndns.org>
On Mon, Jul 07, 2008 at 12:54:41PM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > On Mon, Jul 07, 2008 at 09:02:37PM +0200, Mike Hommey wrote:
> >> http-push test has been broken by 4a7aaccd adding a space character
> >> in the place where the test is being run.
> >> ---
> >>
> >> Note that the 4th test doesn't pass because of the new git clone, that
> >> creates the clone with packed-refs instead of refs/heads/master that
> >> push is requiring. But this also means push was already broken with
> >> repositories with packed-refs.
> >
> > Actually, the 3rd is failing too, but fails to report an error because
> > git push returns no error code in cases where it says:
> > No refs in common and none specified; doing nothing.
>
> Ok, when you are done checking, care to send in a replacement patch with
> failing one marked with test_expect_failure?
Shouldn't that be two different patches ? One to fix the spaces problem
and one to handle the fact that builtin-clone broke the tests ?
Mike
next prev parent reply other threads:[~2008-07-07 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 19:02 [PATCH] Fix http-push test Mike Hommey
2008-07-07 19:08 ` Mike Hommey
2008-07-07 19:54 ` Junio C Hamano
2008-07-07 20:17 ` Mike Hommey [this message]
2008-07-07 21:06 ` [PATCH] Catch failures from t5540-http-push Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707201720.GA1356@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).