From: Sylvain Joyeux <sylvain.joyeux@dfki.de>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Lars Hjemli <hjemli@gmail.com>, Ping Yin <pkufranky@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] fix "git-submodule add a/b/c/repository"
Date: Tue, 8 Jul 2008 10:08:48 +0200 [thread overview]
Message-ID: <20080708080848.GC3628@joyeux> (raw)
In-Reply-To: <4872DE54.5010804@gmail.com>
On Mon, Jul 07, 2008 at 11:26:12PM -0400, Mark Levedahl wrote:
> Junio C Hamano wrote:
>> I'd like to hear clarifications on two counts, please?
>> (1) If Sylvain wanted to have that appear at dir0/dir1/init not init,
>> would it have been sufficient to give that path twice (once for
>> <repository> and another for <path> parameter) to make things work as
>> expected?
>>
> git-submodule really requires two arguments:
Then it should raise an error when the following is given
git submodule add ./relative-path-in-repo
which, for now, is accepted as
git submodule add ./relative-path-in-repo ./relative-path-in-repo
(and confused me into thinking it was a normal behaviour)
Sylvain
prev parent reply other threads:[~2008-07-08 8:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:00 [PATCH] fix "git-submodule add a/b/c/repository" Sylvain Joyeux
2008-07-06 6:27 ` Junio C Hamano
2008-07-06 16:11 ` Sylvain Joyeux
2008-07-06 19:05 ` Mark Levedahl
2008-07-07 6:34 ` Sylvain Joyeux
2008-07-08 2:23 ` Mark Levedahl
2008-07-08 2:42 ` Junio C Hamano
2008-07-08 3:26 ` Mark Levedahl
2008-07-08 6:02 ` Junio C Hamano
2008-07-08 23:57 ` Mark Levedahl
2008-07-09 3:59 ` [PATCH] git-submodule - make "submodule add" more strict, and document it Mark Levedahl
2008-07-09 6:04 ` Junio C Hamano
2008-07-10 1:05 ` Mark Levedahl
2008-07-10 1:05 ` [PATCH] git-submodule - register submodule URL if adding in place Mark Levedahl
2008-07-08 8:08 ` Sylvain Joyeux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708080848.GC3628@joyeux \
--to=sylvain.joyeux@dfki.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=mlevedahl@gmail.com \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).