From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Habouzit Subject: Re: [PATCH 1/6] revisions: refactor init_revisions and setup_revisions. Date: Tue, 08 Jul 2008 13:06:24 +0200 Message-ID: <20080708110624.GF19202@artemis.madism.org> References: <1215510964-16664-1-git-send-email-madcoder@debian.org> <1215510964-16664-2-git-send-email-madcoder@debian.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="dgjlcl3Tl+kb3YDk"; protocol="application/pgp-signature"; micalg=SHA1 Cc: git@vger.kernel.org, torvalds@linux-foundation.org, gitster@pobox.com, peff@peff.net To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Jul 08 13:07:33 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KGB2d-0002uP-9n for gcvg-git-2@gmane.org; Tue, 08 Jul 2008 13:07:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbYGHLG1 (ORCPT ); Tue, 8 Jul 2008 07:06:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754091AbYGHLG1 (ORCPT ); Tue, 8 Jul 2008 07:06:27 -0400 Received: from pan.madism.org ([88.191.52.104]:56554 "EHLO hermes.madism.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbYGHLG0 (ORCPT ); Tue, 8 Jul 2008 07:06:26 -0400 Received: from madism.org (APuteaux-103-1-3-109.w217-128.abo.wanadoo.fr [217.128.49.109]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "artemis.madism.org", Issuer "madism.org" (verified OK)) by hermes.madism.org (Postfix) with ESMTPS id CA2423435D; Tue, 8 Jul 2008 13:06:25 +0200 (CEST) Received: by madism.org (Postfix, from userid 1000) id C586ADC9C; Tue, 8 Jul 2008 13:06:24 +0200 (CEST) Mail-Followup-To: Pierre Habouzit , Johannes Schindelin , git@vger.kernel.org, torvalds@linux-foundation.org, gitster@pobox.com, peff@peff.net Content-Disposition: inline In-Reply-To: X-Face: $(^e[V4D-[`f2EmMGz@fgWK!e.B~2g.{08lKPU(nc1J~z\4B>*JEVq:E]7G-\6$Ycr4<;Z!|VY6Grt]+RsS$IMV)f>2)M="tY:ZPcU;&%it2D81X^kNya0=L]"vZmLP+UmKhgq+u*\.dJ8G!N&=EvlD User-Agent: Madmutt/devel (Linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --dgjlcl3Tl+kb3YDk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 08, 2008 at 10:59:43AM +0000, Johannes Schindelin wrote: > Hi, >=20 > On Tue, 8 Jul 2008, Pierre Habouzit wrote: >=20 > > setup_revisions has been split in two: parse_revisions that does=20 > > (almost) only argument parsing, to be more like what parse-options can= =20 > > do, and setup_revisions that does the rest. >=20 > I do not see the sense of this change, except Well, it's required to remove "parse_revisions" at once if we one day reach the goal of having only parse-opt based parsers. > - blowing up your patch unnecessarily, > - making it more inconvenient for users, and It makes it convenient for parse-opt based parser, and it makes it convenient for people that don't have arguments to parse (and those are many). > - adding an opportunity for bugs to creep in. >=20 > In other words, I would like to see the semantics of setup_revisions()=20 > untouched. FWIW like said I already submitted that patch under different versions in the past, and I seem to recall that it was welcomed as it splits the rev_info final fixups from the argument parsing which are quite different steps. FWIW I really like the new semantics better. If you're worried about the fact that people may be confused about the new semantics, fine, let's rename it then. --=20 =C2=B7O=C2=B7 Pierre Habouzit =C2=B7=C2=B7O madcoder@debia= n.org OOO http://www.madism.org --dgjlcl3Tl+kb3YDk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkhzSjAACgkQvGr7W6HudhzrAwCePD93iXyKAW44osCl/mYz/Knu NT0AoIph1G0OQSoVNMgrd0dvrbcIV8Zc =+Ffn -----END PGP SIGNATURE----- --dgjlcl3Tl+kb3YDk--