git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Beyer <s-beyer@gmx.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] rerere: Separate libgit and builtin functions
Date: Wed, 9 Jul 2008 14:00:30 +0200	[thread overview]
Message-ID: <20080709120030.GA10528@leksak.fem-net> (raw)
In-Reply-To: <alpine.DEB.1.00.0807091355220.5277@eeepc-johanness>

> > This patch moves rerere()-related functions into a newly created 
> > rerere.c file.  Also setup_rerere() is moved into rerere.c to decrease 
> > code duplications for rerere.c and builtin-rerere.c.
> 
> It is not moved to decrease code duplication, but because it is needed by 
> rerere().

Right.

And btw the patch seems to be broken. (At least I can't apply it
here...)   Sorry :( Usually I test applying before sending but this time
lunch was eliciting.

Well, I'm going to fix that.

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F

  reply	other threads:[~2008-07-09 12:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-09  0:17 [PATCH] git-rerere.txt: Mention rr-cache directory Stephan Beyer
2008-07-09  0:25 ` Johannes Schindelin
2008-07-09  0:38   ` Johannes Schindelin
2008-07-09  1:09     ` Junio C Hamano
2008-07-09  9:21     ` Stephan Beyer
2008-07-09 10:18     ` [PATCH] rerere: Separate libgit and builtin functions Stephan Beyer
2008-07-09 11:55       ` Johannes Schindelin
2008-07-09 12:00         ` Stephan Beyer [this message]
2008-07-09 12:58           ` [PATCHv2] " Stephan Beyer
2008-07-09 12:03       ` [PATCH] " Johannes Schindelin
2008-07-09 18:25         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080709120030.GA10528@leksak.fem-net \
    --to=s-beyer@gmx.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).