From: Miklos Vajna <vmiklos@frugalware.org>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: Thomas Rast <trast@student.ethz.ch>, Petr Baudis <pasky@suse.cz>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [StGIT] Failure to install on RHELWS4
Date: Fri, 11 Jul 2008 22:07:35 +0200 [thread overview]
Message-ID: <20080711200735.GK10347@genesis.frugalware.org> (raw)
In-Reply-To: <200807112126.39729.trast@student.ethz.ch>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Fri, Jul 11, 2008 at 09:26:29PM +0200, Thomas Rast <trast@student.ethz.ch> wrote:
> > pyver = '.'.join(str(n) for n in sys.version_info)
> > ^
> [...]
> > Python version is 2.3.4
>
> That is indeed too old. Generator expressions like the above were
> introduced in 2.4:
>
> http://www.python.org/dev/peps/pep-0289/
So obviously it's a bad idea to use generators for such a version check.
Also, setup.py would try to import stgit.run before the version check.
I'm sending two patches, which restore the wished "Python version 2.4 or
newer required. Found 2.2.1.final.0" error message.
(Tested with Python 2.2.1.)
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-07-11 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 17:03 [StGIT] Failure to install on RHELWS4 Petr Baudis
2008-07-11 19:26 ` Thomas Rast
2008-07-11 20:07 ` Miklos Vajna [this message]
2008-07-11 20:09 ` [PATCH] setup.py: fix error message when running with python-2.3 Miklos Vajna
2008-07-12 5:19 ` Karl Hasselström
2008-07-11 20:09 ` [PATCH] setup.py: don't try to import stgit.run before the python version check Miklos Vajna
2008-07-16 4:39 ` Karl Hasselström
2008-07-11 21:35 ` [StGIT] Failure to install on RHELWS4 Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711200735.GK10347@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).