git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>, Petr Baudis <pasky@suse.cz>,
	git@vger.kernel.org
Subject: Re: [PATCH] bash completion: Fix the . -> .. revision range completion
Date: Mon, 14 Jul 2008 06:27:55 +0000	[thread overview]
Message-ID: <20080714062755.GA15992@spearce.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0807132210430.3305@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, 14 Jul 2008, Shawn O. Pearce wrote:
> > > 
> > > Does it fix this one too:
> > > 
> > > 	git show origin/pu:Makef<tab>
> > > 
> > > which totally screws up and becomes
> > > 
> > > 	git show Makefile
> > > 
> > > dropping the version specifier?

What is $COMP_WORDBREAKS set to in your shell?  In mine it
appears to be:

	" \"'@><=;|&(:"

which is the I believe the shell default.

Björn Steinbrink (doener on #git) is running bash 3.2.39 from
Debian and has the same setting, and the completion works correctly
there too.  He reports that removing : from COMP_WORDBREAKS will
get the behavior you are reporting as broken.

I have to say, this sounds to me like you (or some package on your
system) modified COMP_WORDBREAKS away from the default that other
distributions use and that is what is breaking us here.  Since we
can have only one setting for this variable in the shell I do not
thing it would be a good idea for our completion package to force
a specific setting upon the user.

Though we could try to detect : in there and if it is not present
use the workaround you posted.  But I wonder if just asking the
user to include : is easier.

-- 
Shawn.

  parent reply	other threads:[~2008-07-14  6:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-13 11:19 [PATCH] bash completion: Fix the . -> .. revision range completion Petr Baudis
2008-07-13 12:11 ` Jakub Narebski
2008-07-13 21:38 ` Junio C Hamano
2008-07-13 22:06   ` Shawn O. Pearce
2008-07-13 23:07   ` Petr Baudis
2008-07-13 23:25     ` Junio C Hamano
2008-07-13 23:52       ` Linus Torvalds
2008-07-14  0:00         ` Shawn O. Pearce
2008-07-14  5:38           ` Linus Torvalds
2008-07-14  5:57             ` Shawn O. Pearce
2008-07-14  6:27             ` Shawn O. Pearce [this message]
2008-07-14  6:47               ` Björn Steinbrink
2008-07-14  6:50                 ` Björn Steinbrink
2008-07-14 12:39                   ` Andreas Ericsson
2008-07-14 14:51                   ` Linus Torvalds
2008-07-14 14:50               ` Linus Torvalds
2008-07-15  4:25                 ` Shawn O. Pearce
2008-07-15  8:05                   ` Andreas Ericsson
2008-07-15  8:10                     ` Andreas Ericsson
2008-07-15  8:17                       ` Andreas Ericsson
2008-07-15 23:38                     ` Shawn O. Pearce
2008-07-16  7:20                       ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080714062755.GA15992@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pasky@suse.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).