From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH (GIT-GUI) 0/3] Improve gui blame usability for large repositories
Date: Thu, 17 Jul 2008 02:16:23 +0000 [thread overview]
Message-ID: <20080717021623.GC16740@spearce.org> (raw)
In-Reply-To: <200807170042.29462.angavrilov@gmail.com>
Alexander Gavrilov <angavrilov@gmail.com> wrote:
> Full copy detection can take quite some time on large repositories, which
> substantially decreases perceived usability of the 'git gui blame' command.
> This set of patches tries to overcome it by:
>
> 1) Allowing the user to disable '-C -C' and/or set the detection threshold.
>
> 2) Explicitly killing back-end processes, which don't produce any output
> during copy detection, and thus normally won't receive SIGPIPE until
> it is finished. Runaway processes are annoying.
>
> 3) To compensate for (1), adding a context menu item to manually invoke
> blame -C -C -C on a group of lines.
This series is nicely done. Works well on revision.c in git.git,
where the blame can be costly to compute with full copy detection.
And getting the incremental from the context menu also works well.
Thanks.
--
Shawn.
next prev parent reply other threads:[~2008-07-17 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 20:42 [PATCH (GIT-GUI) 0/3] Improve gui blame usability for large repositories Alexander Gavrilov
2008-07-16 20:43 ` [PATCH (GIT-GUI) 1/3] Add options to control the search for copies in blame Alexander Gavrilov
2008-07-16 20:48 ` [PATCH (GIT-GUI) 2/3] Kill the blame back-end on window close Alexander Gavrilov
2008-07-16 20:51 ` [PATCH (GIT-GUI) 3/3] Add a menu item to invoke full copy detection in blame Alexander Gavrilov
2008-07-17 2:16 ` Shawn O. Pearce [this message]
2008-07-18 5:39 ` [PATCH (GIT-GUI) 0/3] Improve gui blame usability for large repositories Alexander Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717021623.GC16740@spearce.org \
--to=spearce@spearce.org \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).