* [PATCH] guilt(1): fix path to git-sh-setup
@ 2008-07-16 23:23 Alex Chiang
2008-07-17 10:02 ` Petr Baudis
2008-07-17 14:53 ` Josef 'Jeff' Sipek
0 siblings, 2 replies; 4+ messages in thread
From: Alex Chiang @ 2008-07-16 23:23 UTC (permalink / raw)
To: jeffpc; +Cc: git
git is in the process of moving subcommands to /usr/libexec/git-core
This move breaks an assumption in guilt about the location of
git-sh-setup.
We can ask git for where it thinks its executables live.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
diff --git a/guilt b/guilt
index 50414a4..ba4593a 100755
--- a/guilt
+++ b/guilt
@@ -23,7 +23,7 @@ esac
# we change directories ourselves
SUBDIRECTORY_OK=1
-. git-sh-setup
+. `git --exec-path`/git-sh-setup
#
# Git version check
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] guilt(1): fix path to git-sh-setup
2008-07-16 23:23 [PATCH] guilt(1): fix path to git-sh-setup Alex Chiang
@ 2008-07-17 10:02 ` Petr Baudis
2008-07-17 11:58 ` Johannes Schindelin
2008-07-17 14:53 ` Josef 'Jeff' Sipek
1 sibling, 1 reply; 4+ messages in thread
From: Petr Baudis @ 2008-07-17 10:02 UTC (permalink / raw)
To: Alex Chiang, jeffpc, git
On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:
> diff --git a/guilt b/guilt
> index 50414a4..ba4593a 100755
> --- a/guilt
> +++ b/guilt
> @@ -23,7 +23,7 @@ esac
> # we change directories ourselves
> SUBDIRECTORY_OK=1
>
> -. git-sh-setup
> +. `git --exec-path`/git-sh-setup
Beware of the proverbial "/Program Files/Git" location, however.
Petr "Pasky" Baudis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] guilt(1): fix path to git-sh-setup
2008-07-17 10:02 ` Petr Baudis
@ 2008-07-17 11:58 ` Johannes Schindelin
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Schindelin @ 2008-07-17 11:58 UTC (permalink / raw)
To: Petr Baudis; +Cc: Alex Chiang, jeffpc, git
Hi,
On Thu, 17 Jul 2008, Petr Baudis wrote:
> On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:
> > diff --git a/guilt b/guilt
> > index 50414a4..ba4593a 100755
> > --- a/guilt
> > +++ b/guilt
> > @@ -23,7 +23,7 @@ esac
> > # we change directories ourselves
> > SUBDIRECTORY_OK=1
> >
> > -. git-sh-setup
> > +. `git --exec-path`/git-sh-setup
>
> Beware of the proverbial "/Program Files/Git" location, however.
Indeed. And when trying to stray not _too_ far away from the coding style
of git.git, avoid the backticks, too, like so:
. "$(git --exec-path)"/git-sh-setup
Ciao,
Dscho
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] guilt(1): fix path to git-sh-setup
2008-07-16 23:23 [PATCH] guilt(1): fix path to git-sh-setup Alex Chiang
2008-07-17 10:02 ` Petr Baudis
@ 2008-07-17 14:53 ` Josef 'Jeff' Sipek
1 sibling, 0 replies; 4+ messages in thread
From: Josef 'Jeff' Sipek @ 2008-07-17 14:53 UTC (permalink / raw)
To: Alex Chiang, git
On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote:
> git is in the process of moving subcommands to /usr/libexec/git-core
>
> This move breaks an assumption in guilt about the location of
> git-sh-setup.
I already have a fix for this queued up.
Thanks anyway,
Josef 'Jeff' Sipek.
P.S. Pasky: good catch, I'll check the queued up patch to make sure it's not
"broken"
--
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-17 14:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-16 23:23 [PATCH] guilt(1): fix path to git-sh-setup Alex Chiang
2008-07-17 10:02 ` Petr Baudis
2008-07-17 11:58 ` Johannes Schindelin
2008-07-17 14:53 ` Josef 'Jeff' Sipek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).