From: Dmitry Potapov <dpotapov@gmail.com>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Remove function stubs in shell.c
Date: Fri, 18 Jul 2008 10:06:34 +0400 [thread overview]
Message-ID: <20080718060634.GK2925@dpotapov.dyndns.org> (raw)
In-Reply-To: <1216343197-20290-1-git-send-email-s-beyer@gmx.net>
On Fri, Jul 18, 2008 at 03:06:37AM +0200, Stephan Beyer wrote:
> These function stubs may be useful, but because they redefine
> functions, they provoke a linker error.
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
> Or would you rather like this one? ;)
Unfortunately, this one will increase the size of git-shell
considerably:
text data bss dec hex filename
18182 824 8232 27238 6a66 git-shell
===
text data bss dec hex filename
146738 1376 93164 241278 3ae7e git-shell
So, personally, I don't like it.
Dmitry
next prev parent reply other threads:[~2008-07-18 6:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 21:35 [PATCH] shrink git-shell by avoiding redundant dependencies Dmitry Potapov
2008-06-27 21:55 ` Junio C Hamano
2008-06-27 22:31 ` Dmitry Potapov
2008-06-27 22:34 ` Junio C Hamano
2008-07-18 0:26 ` Stephan Beyer
2008-07-18 0:58 ` Shawn O. Pearce
2008-07-18 1:04 ` [PATCH] Link git-shell only to a subset of libgit.a Stephan Beyer
2008-07-18 1:06 ` Shawn O. Pearce
2008-07-18 6:03 ` Dmitry Potapov
2008-07-18 10:55 ` Johannes Schindelin
2008-07-18 1:06 ` [PATCH] Remove function stubs in shell.c Stephan Beyer
2008-07-18 6:06 ` Dmitry Potapov [this message]
2008-07-18 5:59 ` [PATCH] shrink git-shell by avoiding redundant dependencies Dmitry Potapov
2008-06-28 14:51 ` Johannes Schindelin
2008-06-28 16:48 ` Dmitry Potapov
2008-06-28 17:31 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718060634.GK2925@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s-beyer@gmx.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).