From: Miklos Vajna <vmiklos@frugalware.org>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] builtin-merge: missing structure bzero.
Date: Mon, 21 Jul 2008 19:21:19 +0200 [thread overview]
Message-ID: <20080721172119.GE32057@genesis.frugalware.org> (raw)
In-Reply-To: <1216659830-22063-1-git-send-email-madcoder@debian.org>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
On Mon, Jul 21, 2008 at 07:03:50PM +0200, Pierre Habouzit <madcoder@debian.org> wrote:
> This cause segfaults when replacing a directory with a submodule in a
> fast-forward.
Thanks.
> +test_expect_failure 'Replace a directory with a submodule, with a file conflict' '
> + mkdir test &&
> + cd test &&
> + : create our repository with a sub/a file &&
> + git init &&
> + mkdir sub && echo a > sub/a &&
> + git add sub && git commit -asm"initial repository" &&
> + : save this state in a new branch &&
> + git branch temp &&
> + : then replace sub with it &&
> + git rm -rf sub &&
> + git submodule add -- "$(pwd)/../submodule/.git/" sub &&
> + git commit -asm "replace sub/ with a submodule" &&
> + : then try to update the "temp" branch &&
> + git checkout temp &&
It seems this one fails. I guess this will be a problem in the low-level
merge code (read-tree -m) and not in builtin-merge.
> + git merge master &&
> + : and finally cleanse the mess &&
> + cd .. &&
> + rm -rf test
> +'
> +
> +test_done
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-07-21 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 17:03 [PATCH] builtin-merge: missing structure bzero Pierre Habouzit
2008-07-21 17:21 ` Miklos Vajna [this message]
2008-07-21 18:18 ` Pierre Habouzit
2008-07-21 21:49 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721172119.GE32057@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox