From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: git status in clean working dir Date: Tue, 22 Jul 2008 00:52:23 -0400 Message-ID: <20080722045223.GC20787@sigill.intra.peff.net> References: <0ttzeirft8.wl%bremner@pivot.cs.unb.ca> <7vy73ur6pz.fsf@gitster.siamese.dyndns.org> <7vtzeir68z.fsf@gitster.siamese.dyndns.org> <7vljzur5wd.fsf@gitster.siamese.dyndns.org> <20080722044359.GB20787@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, David Bremner To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Jul 22 06:53:26 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KL9sL-0006Hm-Iy for gcvg-git-2@gmane.org; Tue, 22 Jul 2008 06:53:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756626AbYGVEw0 (ORCPT ); Tue, 22 Jul 2008 00:52:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751865AbYGVEw0 (ORCPT ); Tue, 22 Jul 2008 00:52:26 -0400 Received: from peff.net ([208.65.91.99]:2453 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756626AbYGVEwY (ORCPT ); Tue, 22 Jul 2008 00:52:24 -0400 Received: (qmail 2435 invoked by uid 111); 22 Jul 2008 04:52:23 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.32) with ESMTP; Tue, 22 Jul 2008 00:52:23 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 22 Jul 2008 00:52:23 -0400 Content-Disposition: inline In-Reply-To: <20080722044359.GB20787@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Jul 22, 2008 at 12:44:00AM -0400, Jeff King wrote: > We could also swap the parent/child relationship, and have the pager as > child. But I assume that it is done the way we have it because otherwise > the shell gets confused about when the command ends (i.e., we want it to > run until pager completion). I didn't test, though. Hmm, it looks like the MINGW32 codepath already _does_ spawn in that order, but has a "wait_for_child" atexit handler. I wonder if there is a reason all platforms can't use that trick (though the mingw approach uses run_command, which makes it harder to do the "wait for input before starting less" trick). -Peff