From: Jeff King <peff@peff.net>
To: Mike Hommey <mh@glandium.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, David Bremner <bremner@unb.ca>
Subject: Re: [PATCH 2/2] spawn pager via run_command interface
Date: Tue, 22 Jul 2008 03:16:30 -0400 [thread overview]
Message-ID: <20080722071630.GA3669@sigill.intra.peff.net> (raw)
In-Reply-To: <20080722071411.GB3584@sigill.intra.peff.net>
On Tue, Jul 22, 2008 at 03:14:12AM -0400, Jeff King wrote:
> static struct child_process pager_process = {
> .argv = pager_argv,
> - .in = -1
> + .in = -1,
> +#ifndef __MINGW32__
> + .preexec_cb = pager_preexec,
> +#endif
I couldn't recall if this initializer style is portable enough for us.
It was already there wrapped in ifdefs, but perhaps it was only ok
because the mingw version always uses the same compiler?
-Peff
next prev parent reply other threads:[~2008-07-22 7:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 23:13 git status in clean working dir David Bremner
2008-07-22 2:30 ` Junio C Hamano
2008-07-22 2:36 ` Abhijit Menon-Sen
2008-07-22 2:40 ` Junio C Hamano
2008-07-22 2:48 ` Junio C Hamano
2008-07-22 4:44 ` Jeff King
2008-07-22 4:52 ` Jeff King
2008-07-22 11:24 ` Johannes Schindelin
2008-07-22 4:41 ` Jeff King
2008-07-22 5:39 ` Mike Hommey
2008-07-22 6:06 ` Jeff King
2008-07-22 6:18 ` Mike Hommey
2008-07-22 6:46 ` Jeff King
2008-07-22 7:10 ` Jeff King
2008-07-22 7:12 ` [PATCH 1/2] run-command: add pre-exec callback Jeff King
2008-07-22 7:14 ` [PATCH 2/2] spawn pager via run_command interface Jeff King
2008-07-22 7:16 ` Jeff King [this message]
2008-07-22 7:31 ` Pierre Habouzit
2008-07-22 7:49 ` Jeff King
2008-07-22 7:48 ` Johannes Sixt
2008-07-22 7:50 ` Jeff King
2008-07-22 8:29 ` Johannes Sixt
2008-07-22 9:17 ` git status in clean working dir Junio C Hamano
2008-07-22 9:40 ` Jeff King
2008-07-22 14:10 ` David Bremner
2008-07-22 7:34 ` Johannes Sixt
2008-07-22 7:46 ` Jeff King
2008-07-22 7:54 ` Johannes Sixt
2008-07-24 6:56 ` Ask Bjørn Hansen
2008-07-24 16:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722071630.GA3669@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bremner@unb.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).