From: Petr Baudis <pasky@suse.cz>
To: "Nguy???n Thái Ng???c Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 02/12] git-grep: support --no-external-grep
Date: Wed, 23 Jul 2008 21:01:30 +0200 [thread overview]
Message-ID: <20080723190129.GM32184@machine.or.cz> (raw)
In-Reply-To: <20080723145744.GA29156@laptop> <20080723145718.GA29134@laptop> <20080723145603.GA29079@laptop> <20080723145549.GA29067@laptop>
Hi,
the patches 2, 3, 8 and 10 of your series introduce config options,
commandline switches and environment variables that are not documented
anywhere - can you please include documentation updates in your patch
series as well? It might be worth it to find some suitable place in the
documentation where to explain the concept itself; it took me quite
sometime before I actually realized (I think) what are your patches
about. (Which is also why is it useful to write cover letters for
patch series.)
--
Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name. -- Ken Thompson and Dennis M. Ritchie
next prev parent reply other threads:[~2008-07-23 19:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 14:57 [PATCH 10/12] git-checkout: support --full and --path to manipulate sparse checkout Nguyễn Thái Ngọc Duy
2008-07-23 14:57 ` [PATCH 08/12] git-clone: support --path to do sparse clone Nguyễn Thái Ngọc Duy
2008-07-23 14:56 ` [PATCH 03/12] Introduce sparse prefix Nguyễn Thái Ngọc Duy
2008-07-23 14:55 ` [PATCH 02/12] git-grep: support --no-external-grep Nguyễn Thái Ngọc Duy
2008-07-23 19:01 ` Petr Baudis [this message]
2008-07-23 19:05 ` Petr Baudis
2008-07-24 20:26 ` Alex Riesen
2008-07-24 23:16 ` Nguyen Thai Ngoc Duy
2008-07-24 17:19 ` [PATCH 08/12] git-clone: support --path to do sparse clone Jeff King
2008-07-24 17:41 ` sparse fetch, was " Johannes Schindelin
2008-07-24 18:28 ` Jeff King
2008-07-25 0:09 ` Johannes Schindelin
2008-07-25 0:46 ` James Pickens
2008-07-25 0:49 ` sparse fetch, was Re: [PATCH 08/12] git-clone: support --path?to " Jeff King
2008-07-25 8:47 ` sparse fetch, was Re: [PATCH 08/12] git-clone: support --path to " Junio C Hamano
2008-07-25 8:54 ` Sverre Rabbelier
2008-07-24 18:44 ` Nguyen Thai Ngoc Duy
2008-07-24 18:53 ` Petr Baudis
2008-07-24 19:01 ` Sverre Rabbelier
2008-07-25 0:12 ` Johannes Schindelin
2008-07-25 0:42 ` Petr Baudis
2008-07-25 8:14 ` Sverre Rabbelier
2008-07-24 18:47 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723190129.GM32184@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).