From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Nicolas Pitre <nico@cam.org>,
spearce@spearce.org, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] index-pack: correctly initialize appended objects
Date: Thu, 24 Jul 2008 20:07:10 +0200 [thread overview]
Message-ID: <20080724180710.GA26088@atjola.homenet> (raw)
In-Reply-To: <alpine.DEB.1.00.0807241821440.8986@racer>
On 2008.07.24 18:32:00 +0100, Johannes Schindelin wrote:
>
> From: Björn Steinbrink <B.Steinbrink@gmx.de>
>
> When index-pack completes a thin pack it appends objects to the pack.
> Since the commit 92392b4(index-pack: Honor core.deltaBaseCacheLimit when
> resolving deltas) such an object can be pruned in case of memory
> pressure.
>
> To be able to re-read the object later, a few more fields have to be set.
Ah, thanks a lot! I tried to come up with a sane commit message
yesterday but totally failed, and then after a night of sneezing, I had
forgotten about it. And I wouldn't have managed to write an equally good
message anyway ;-)
> Noticed by Pierre Habouzit.
>
> Hopefully-signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Sure!
Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Thanks,
Björn
next prev parent reply other threads:[~2008-07-24 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 17:32 [PATCH] index-pack: correctly initialize appended objects Johannes Schindelin
2008-07-24 18:07 ` Björn Steinbrink [this message]
2008-07-25 5:21 ` Junio C Hamano
2008-07-25 10:24 ` Johannes Schindelin
2008-07-25 11:54 ` Nicolas Pitre
2008-07-25 12:01 ` Björn Steinbrink
2008-07-25 12:24 ` Nicolas Pitre
2008-07-25 18:15 ` Junio C Hamano
2008-07-25 11:55 ` Björn Steinbrink
2008-07-25 13:15 ` Johannes Schindelin
2008-07-25 16:42 ` Shawn O. Pearce
2008-07-25 17:13 ` Björn Steinbrink
2008-07-25 17:20 ` Shawn O. Pearce
2008-07-26 3:04 ` Johannes Schindelin
2008-07-25 11:48 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724180710.GA26088@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox