From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Peter Valdemar Mørch" <4ux6as402@sneakemail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Avoid warning when From: is encoded
Date: Fri, 25 Jul 2008 14:38:57 -0400 [thread overview]
Message-ID: <20080725183857.GE4375@sigill.intra.peff.net> (raw)
In-Reply-To: <7vhcadudmz.fsf@gitster.siamese.dyndns.org>
On Fri, Jul 25, 2008 at 09:33:56AM -0700, Junio C Hamano wrote:
> > In commit 0706bd19ef9b41e7519df2c73796ef93484272fd $1 is used from a regexp
> > without using () to set up $1. Later, when that value was used, it caused a
> > warning about a variable being undefined.
> >
> > Signed-off-by: Peter Valdemar Mørch <peter@morch.com>
>
> Thanks. The patch is obviously correct; I think you are fixing 8291db6
> (git-send-email: add charset header if we add encoded 'From', 2007-11-16),
> not 0706bd1 (send-email: specify content-type of --compose body,
> 2008-03-28).
>
> Will apply to maint and merge upwards.
Discussions about who can ACK this code aside, the original bogosity was
totally mine, so
Acked-by: Jeff King <peff@peff.net>
-Peff
prev parent reply other threads:[~2008-07-25 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 13:06 [PATCH] Avoid warning when From: is encoded Peter Valdemar Mørch
2008-07-25 13:16 ` Abhijit Menon-Sen
2008-07-25 16:01 ` Sverre Rabbelier
2008-07-25 16:39 ` Jon Loeliger
2008-07-26 2:53 ` Johannes Schindelin
2008-07-25 16:33 ` Junio C Hamano
2008-07-25 18:38 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725183857.GE4375@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=4ux6as402@sneakemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).