* how about removing --exec-path?
@ 2008-07-25 9:40 Alex Riesen
2008-07-26 2:49 ` Johannes Schindelin
0 siblings, 1 reply; 3+ messages in thread
From: Alex Riesen @ 2008-07-25 9:40 UTC (permalink / raw)
To: git
The thing has at least this problem: is not passed to upload-pack when
running fetch. So upload-pack, everything past it gets called either
from GIT_EXEC_PATH (which usually is not set) or from builtin exec
path (and that's annoying when debugging for instance index-pack).
The feature has a stable alternative ($GIT_EXEC_PATH) anyway.
Or maybe just replace the whole argv_exec_path handling with a plain
setenv("GIT_EXEC_PATH", exec_path, 1)?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: how about removing --exec-path?
2008-07-25 9:40 how about removing --exec-path? Alex Riesen
@ 2008-07-26 2:49 ` Johannes Schindelin
2008-07-26 6:48 ` Alex Riesen
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2008-07-26 2:49 UTC (permalink / raw)
To: Alex Riesen; +Cc: git
Hi,
On Fri, 25 Jul 2008, Alex Riesen wrote:
> The thing has at least this problem: is not passed to upload-pack when
> running fetch.
It should be added to PATH, and so it is passed to upload-pack, amongst
others, in a sense.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: how about removing --exec-path?
2008-07-26 2:49 ` Johannes Schindelin
@ 2008-07-26 6:48 ` Alex Riesen
0 siblings, 0 replies; 3+ messages in thread
From: Alex Riesen @ 2008-07-26 6:48 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git
Johannes Schindelin, Sat, Jul 26, 2008 04:49:06 +0200:
> On Fri, 25 Jul 2008, Alex Riesen wrote:
>
> > The thing has at least this problem: is not passed to upload-pack when
> > running fetch.
>
> It should be added to PATH, and so it is passed to upload-pack, amongst
> others, in a sense.
>
Yes, but next time upload-pack runs a program, it adds builtin exec
path to PATH (because --exec-path not given to transport's uploadpack
command). So it looks like this:
$GIT_EXEC_PATH:/usr/local/libexec/git-core:/orig/exec-path:\
$GIT_EXEC_PATH:/usr/local/libexec/git-core:$ORIG_USER_PATH
which kind of useless for debugging. So using GIT_EXEC_PATH is the
only way (and why did we need more? Working around something?)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-26 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 9:40 how about removing --exec-path? Alex Riesen
2008-07-26 2:49 ` Johannes Schindelin
2008-07-26 6:48 ` Alex Riesen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).