From: "Shawn O. Pearce" <spearce@spearce.org>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)
Date: Mon, 28 Jul 2008 22:24:59 -0700 [thread overview]
Message-ID: <20080729052459.GC11947@spearce.org> (raw)
In-Reply-To: <1217308647-23673-1-git-send-email-prohaska@zib.de>
Steffen Prohaska <prohaska@zib.de> wrote:
> We prefer running the dashless form, so we should use it in MinGW's
> start_command(), too.
...
> - We have non-builtins that are implemented in C, e.g. fast-import.c.
> These non-builtins will still compute wrong paths.
This feels wrong to me. fast-import probably won't be adversly
impacted by not being able to read /etc/gitconfig, unless the user
has set something like core.deltaBaseCacheLimit and is doing an
incremental import. But other non-builtins may be impacted.
It feels like we're fixing this in the wrong place. If the issue
is we don't find our installation directory correctly, we should
find our installation directory correctly, not work around it by
calling builtins through the git wrapper.
Though I can see where it may be a good idea to at some point
in the future (git 1.7?) stop creating the redundant builtin
links under libexec/git-core.
--
Shawn.
next prev parent reply other threads:[~2008-07-29 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BF5B7CBE-ACA8-4D81-8FC0-8A7901205854@zib.de>
2008-07-29 5:17 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Steffen Prohaska
2008-07-29 5:17 ` [FOR DEBUGGING] Stop installing BUILT_INS Steffen Prohaska
2008-07-29 5:24 ` Shawn O. Pearce [this message]
2008-07-29 5:42 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Junio C Hamano
2008-07-29 5:55 ` Steffen Prohaska
2008-07-29 11:13 ` Johannes Schindelin
2008-07-29 11:31 ` Steffen Prohaska
2008-07-29 5:51 ` Steffen Prohaska
2008-07-29 11:18 ` Johannes Schindelin
2008-07-29 5:15 [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>" Steffen Prohaska
2008-07-29 5:19 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729052459.GC11947@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).