From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alexander Gavrilov <angavrilov@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH v2] Support copy and rename detection in fast-export.
Date: Tue, 29 Jul 2008 09:45:20 -0700 [thread overview]
Message-ID: <20080729164520.GA1730@spearce.org> (raw)
In-Reply-To: <7v7ib4hdpu.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Alexander Gavrilov <angavrilov@gmail.com> writes:
>
> > Although it does not matter for Git itself, tools that
> > export to systems that explicitly track copies and
> > renames can benefit from such information.
> >
> > This patch makes fast-export output correct action
> > logs when -M or -C are enabled.
> >
> > Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
> > ---
> >
> > On Sunday 27 July 2008 00:21:03 Shawn O. Pearce wrote:
> > > Do you mean to say git-fast-export in the end of the first line of
> > > that last paragraph?
> >
> > Yes, of course. Thank you.
>
> Alexander, Shawn, what is the status of this patch? Has it been reviewed
> sufficiently and is ready for application?
It looked OK to me on the surface, except the one minor remark in
the documentation I noted above. Other than that I am not very good
with the internal diff machinary so my ACK/NACK on such matters is
worth very little, if anything.
--
Shawn.
next prev parent reply other threads:[~2008-07-29 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 8:16 [RFC PATCH] Support copy and rename detection in fast-export Alexander Gavrilov
2008-07-21 10:17 ` Johannes Schindelin
2008-07-26 18:49 ` [PATCH v2] " Alexander Gavrilov
2008-07-26 20:21 ` Shawn O. Pearce
2008-07-26 20:52 ` Alexander Gavrilov
2008-07-29 16:11 ` Junio C Hamano
2008-07-29 16:45 ` Shawn O. Pearce [this message]
2008-07-30 9:10 ` Alexander Gavrilov
2008-07-30 18:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729164520.GA1730@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).