From: Jeff King <peff@peff.net>
To: Anders Melchiorsen <mail@cup.kalibalik.dk>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] Advertise the ability to abort a commit
Date: Wed, 30 Jul 2008 01:11:00 -0400 [thread overview]
Message-ID: <20080730051059.GA4497@sigill.intra.peff.net> (raw)
In-Reply-To: <20080730050715.GA4034@sigill.intra.peff.net>
On Wed, Jul 30, 2008 at 01:07:15AM -0400, Jeff King wrote:
> > - die("no commit message? aborting commit.");
> > + die("no commit message. aborting commit.");
>
> I don't think the change of punctuation makes a big difference here,
> but this could probably stand to be reworded. Maybe:
>
> Aborting commit due to empty commit message.
Using "die" also prepends "fatal: " which is perhaps a bit much for an
expected feature. So maybe:
fprintf(stderr, "Aborting commit due to empty commit message.\n");
exit(1); /* or even some specific "intentional abort" exit code */
-Peff
next prev parent reply other threads:[~2008-07-30 5:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:32 [PATCH] Advertise the ability to abort a commit Anders Melchiorsen
2008-07-29 20:12 ` [PATCH v2] " Anders Melchiorsen
2008-07-29 20:51 ` Junio C Hamano
2008-07-29 21:19 ` Anders Melchiorsen
2008-07-30 5:07 ` Jeff King
2008-07-30 5:11 ` Jeff King [this message]
2008-07-30 17:53 ` [PATCH v3] " Anders Melchiorsen
2008-07-30 19:01 ` Brian Gernhardt
2008-07-30 21:09 ` Avery Pennarun
2008-07-30 21:16 ` Brian Gernhardt
2008-07-30 21:53 ` Anders Melchiorsen
2008-07-31 5:50 ` Jeff King
2008-07-31 5:58 ` Junio C Hamano
2008-07-31 6:36 ` [PATCH] " Jeff King
2008-07-31 7:36 ` [PATCH v3] " Jeff King
2008-07-31 10:55 ` Petr Baudis
2008-07-31 11:09 ` Jeff King
2008-07-31 7:28 ` Anders Melchiorsen
2008-07-31 7:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730051059.GA4497@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@cup.kalibalik.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).