From: Jeff King <peff@peff.net>
To: Kevin Ballard <kevin@sb.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] format-patch: Produce better output with --inline or --attach
Date: Wed, 30 Jul 2008 01:24:01 -0400 [thread overview]
Message-ID: <20080730052401.GC4034@sigill.intra.peff.net> (raw)
In-Reply-To: <1217375356-80287-1-git-send-email-kevin@sb.org>
On Tue, Jul 29, 2008 at 04:49:16PM -0700, Kevin Ballard wrote:
> The first is to write a newline preceding the boundary. This is needed
> because MIME defines the encapsulation boundary as including the
> preceding CRLF (or in this case, just LF), so we should be writing
> one. Without this, the last newline in the pre-diff content is
> consumed instead.
Hmm. I am surprised we haven't had more bug reports about this, but
perhaps these features aren't used too frequently. But I double checked
the MIME specs just to be sure, and you are definitely right.
> The second change is to always write the line termination character (default: newline)
Can you please wrap your commit messages at some more reasonable length?
This line is 86 characters long.
-Peff
next prev parent reply other threads:[~2008-07-30 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 23:49 [PATCH] format-patch: Produce better output with --inline or --attach Kevin Ballard
2008-07-30 5:24 ` Jeff King [this message]
2008-07-30 5:49 ` Kevin Ballard
2008-07-30 14:29 ` Johannes Schindelin
2008-07-30 18:30 ` Kevin Ballard
2008-07-30 18:37 ` Kevin Ballard
2008-07-31 5:52 ` Jeff King
2008-07-30 18:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730052401.GC4034@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).