From: Petr Baudis <pasky@suse.cz>
To: Pierre Habouzit <madcoder@debian.org>,
"H.Merijn Brand" <h.m.brand@xs4all.nl>,
git@vger.kernel.org
Subject: Re: [PATCH] 64bit issue in test-parse-options.c
Date: Thu, 31 Jul 2008 13:07:08 +0200 [thread overview]
Message-ID: <20080731110708.GN32184@machine.or.cz> (raw)
In-Reply-To: <20080730140523.GC31392@artemis.madism.org>
On Wed, Jul 30, 2008 at 04:05:23PM +0200, Pierre Habouzit wrote:
> On Wed, Jul 30, 2008 at 12:44:52PM +0000, H.Merijn Brand wrote:
> > On Wed, 30 Jul 2008 14:37:13 +0200, Pierre Habouzit
> > <madcoder@debian.org> wrote:
> > > long is wrong in the first place, parse-opt only uses ints.
> >
> > If I change it to int, the date parsing goes bogus.
>
> That is because OPT_DATE indeed expect a long (why not a time_t I don't
> know btw... but time_t is a long on linux so it doesn't change things a
> lot).
Still, I think converting to time_t for timestamps would be a good
cleanup; I have added it to http://git.or.cz/gitwiki/Janitor.
Petr "Pasky" Baudis
prev parent reply other threads:[~2008-07-31 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 12:16 [PATCH] 64bit issue in test-parse-options.c H.Merijn Brand
2008-07-30 12:37 ` Pierre Habouzit
2008-07-30 12:44 ` H.Merijn Brand
2008-07-30 14:05 ` Pierre Habouzit
2008-07-30 19:11 ` Junio C Hamano
2008-07-30 19:35 ` Pierre Habouzit
2008-07-30 19:55 ` H.Merijn Brand
2008-07-31 11:07 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731110708.GN32184@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=h.m.brand@xs4all.nl \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).