From: Petr Baudis <pasky@suse.cz>
To: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 0/2] gitweb use sections
Date: Thu, 31 Jul 2008 22:32:50 +0200 [thread overview]
Message-ID: <20080731203250.GO10151@machine.or.cz> (raw)
In-Reply-To: <b1f2b8c40807311243i5689683avcc3c3c91e4e6a900@mail.gmail.com>
Hi,
On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
> Since nobody replied and I missed some gitweb guys in CC, I'm adding
> Petr and Jakub, as some guys said on IRC.
>
> Have anyone tried this patch, any problems?
sorry, I have it in my review queue. At first pass it was looking
good, but I wanted to look at it better before commenting.
One thing I'm wondering about is how to make this stuff configurable,
since I'm not very comfortable with adding more "unbound" configuration
variables and would rather prefer stuff to be added to the $features
array... I'm not at all sure about my own sentiment here, however.
--
Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name. -- Ken Thompson and Dennis M. Ritchie
next prev parent reply other threads:[~2008-07-31 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 2:34 [PATCH 0/2] gitweb use sections Gustavo Sverzut Barbieri
2008-07-29 2:34 ` [PATCH 1/2] gitweb: sort projects by path Gustavo Sverzut Barbieri
2008-07-29 2:34 ` [PATCH 2/2] gitweb: add section support to gitweb project listing Gustavo Sverzut Barbieri
2008-07-29 3:59 ` [PATCH 1/2 v2] gitweb: sort projects by path Gustavo Sverzut Barbieri
2008-07-31 19:43 ` [PATCH 0/2] gitweb use sections Gustavo Sverzut Barbieri
2008-07-31 20:32 ` Petr Baudis [this message]
2008-07-31 20:58 ` Gustavo Sverzut Barbieri
2008-08-10 19:45 ` Gustavo Sverzut Barbieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731203250.GO10151@machine.or.cz \
--to=pasky@suse.cz \
--cc=barbieri@profusion.mobi \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).