git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff: add ruby funcname pattern
Date: Fri, 1 Aug 2008 10:41:54 -0400	[thread overview]
Message-ID: <20080801144153.GA14102@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4p65tadh.fsf@gitster.siamese.dyndns.org>

On Fri, Aug 01, 2008 at 01:20:10AM -0700, Junio C Hamano wrote:

> Thanks again for the patch.  Somewhere I heard that there are 10 Rubyista
> git users for every non Rubyista git user, so I am sure somebody would
> comment on your patch in a day or two.  Perhaps we might even get Python
> and Perl hunk patterns (although I suspect Perl people are happy with the
> default one we stole from GNU diff) to go with it ;-).

I keep a lot of Perl in git, and yes, I am quite happy with the default
regex.

-Peff

  parent reply	other threads:[~2008-08-01 14:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  7:21 [PATCH] diff: add ruby funcname pattern Giuseppe Bilotta
2008-08-01  7:30 ` Junio C Hamano
2008-08-01  8:11   ` Giuseppe Bilotta
2008-08-01  8:20     ` Junio C Hamano
2008-08-01  8:39       ` Giuseppe Bilotta
2008-08-01 14:41       ` Jeff King [this message]
2008-08-02  0:31       ` Kevin Ballard
2008-08-02  3:50         ` Junio C Hamano
2008-08-02  5:41         ` Giuseppe Bilotta
2008-08-02  5:47           ` Kevin Ballard
2008-08-02  6:06             ` Giuseppe Bilotta
2008-08-02 11:39               ` Johannes Schindelin
2008-08-02 11:50                 ` Giuseppe Bilotta
2008-08-02 15:37             ` Lee Marlow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080801144153.GA14102@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).