From: Jan Hudec <bulb@ucw.cz>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Steffen Prohaska <prohaska@zib.de>,
Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Set up argv0_path correctly, even when argv[0] is just the basename
Date: Sun, 3 Aug 2008 22:25:13 +0200 [thread overview]
Message-ID: <20080803202513.GC3482@efreet.light.src> (raw)
In-Reply-To: <alpine.DEB.1.00.0807261613120.26810@eeepc-johanness>
On Sat, Jul 26, 2008 at 16:14:33 +0200, Johannes Schindelin wrote:
> When the program 'git' is in the PATH, the argv[0] is set to the basename.
> However, argv0_path needs the full path, so add a function to discover the
> program by traversing the PATH manually.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> So it is not easily possible to reuse this function in
> compat/mingw.c, as Junio said that compat/ should not depend
> (at least too much) on libgit.a.
>
> Of course, we could try to follow a symlinked git, too, but I
> think this is overkill until someone proves me wrong.
On UNIX, not only that argv[0] can contain the program without path -- it can
contain anything the user thinks of. However most systems provide some way to
get the path of the executable. On Linux (and some other unices, but not all
of them) a reliable way is to readlink("/proc/self/exe", ...). Maybe since
it's only needed for resolving a relative exec dir, relative exec dir could
be supported only on systems that have such method (which is most of them).
--
Jan 'Bulb' Hudec <bulb@ucw.cz>
next prev parent reply other threads:[~2008-08-03 20:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 9:41 [PATCH] Modify mingw_main() workaround to avoid link errors Steffen Prohaska
2008-07-26 13:17 ` Johannes Schindelin
2008-07-26 16:07 ` Steffen Prohaska
2008-07-26 14:14 ` [PATCH] Set up argv0_path correctly, even when argv[0] is just the basename Johannes Schindelin
2008-07-26 14:54 ` Rene Herman
2008-07-26 15:10 ` Johannes Schindelin
2008-07-26 15:19 ` Rene Herman
2008-07-26 15:35 ` Johannes Schindelin
2008-07-26 15:53 ` Rene Herman
2008-07-26 17:31 ` Junio C Hamano
2008-07-26 17:42 ` Johannes Schindelin
2008-08-03 20:25 ` Jan Hudec [this message]
2008-08-03 20:43 ` Junio C Hamano
2008-07-26 20:37 ` [PATCH] Modify mingw_main() workaround to avoid link errors Johannes Sixt
2008-07-26 21:36 ` Steffen Prohaska
2008-07-27 19:24 ` Johannes Sixt
2008-07-29 4:46 ` Steffen Prohaska
2008-07-29 8:33 ` Johannes Sixt
2008-07-29 19:46 ` Steffen Prohaska
2008-08-03 19:55 ` Johannes Sixt
2008-08-03 21:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803202513.GC3482@efreet.light.src \
--to=bulb@ucw.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).