git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Beyer <s-beyer@gmx.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3 v2] Enable parallel tests
Date: Fri, 8 Aug 2008 17:03:59 +0200	[thread overview]
Message-ID: <20080808150359.GA25106@leksak.fem-net> (raw)
In-Reply-To: <alpine.DEB.1.00.0808081302180.9611@pacific.mpi-cbg.de.mpi-cbg.de>

Hi,

Johannes Schindelin wrote:
> @@ -485,7 +490,8 @@ fi
>  . ../GIT-BUILD-OPTIONS
>  
>  # Test repository
> -test="trash directory"
> +test="trash directory.$(basename "$0" .sh)"
> +remove_trash="$(pwd)/$test"
>  rm -fr "$test" || {
>  	trap - exit
>  	echo >&5 "FATAL: Cannot prepare test area"

Please also change t/README, there is a text like:

  [...]
   database and chdir(2) into it.  This directory is 't/trash directory'
   if you must know, but I do not think you care.

If the subdirectory variant is chosen ("trash directory/foo/" instead
of "trash directory.foo/"), then

   This directory is below 't/trash directory'."

could be sufficient.

Btw, Junio, about the passage: "I do not think you care" -- I cared :)
Sometimes it's nice to change to 'trash directory' and do git log, git diff,
git show or whatever.

Regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F

  reply	other threads:[~2008-08-08 15:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  5:59 [PATCH 0/3] Enable parallelized tests Johannes Schindelin
2008-08-08  5:59 ` [PATCH 1/3] t9700: remove useless check Johannes Schindelin
2008-08-08  5:59 ` [PATCH 2/3] tests: Clarify dependencies between tests, 'aggregate-results' and 'clean' Johannes Schindelin
2008-08-08  5:59 ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08  6:52   ` Junio C Hamano
2008-08-08 10:26     ` Johannes Schindelin
2008-08-08 10:33       ` Junio C Hamano
2008-08-08  7:44   ` René Scharfe
2008-08-08  8:28     ` Junio C Hamano
2008-08-08  9:31       ` [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory Junio C Hamano
2008-08-08 10:35         ` Johannes Schindelin
2008-08-08 10:40           ` Junio C Hamano
2008-08-08 14:40             ` Stephan Beyer
2008-08-09 22:53         ` Olivier Marin
2008-08-09 23:20           ` Junio C Hamano
2008-08-10  7:33           ` Junio C Hamano
2008-08-08 10:37     ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08 11:08       ` [PATCH 3/3 v2] " Johannes Schindelin
2008-08-08 15:03         ` Stephan Beyer [this message]
2008-08-08 15:27           ` Johannes Schindelin
2008-08-08 15:36 ` [PATCH 0/3] Enable parallelized tests SZEDER Gábor
2008-08-08 16:02   ` Stephan Beyer
2008-08-08 16:30     ` Johannes Schindelin
2008-08-08 16:33       ` Stephan Beyer
2008-08-08 16:51         ` Johannes Schindelin
2008-08-08 16:56           ` Stephan Beyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080808150359.GA25106@leksak.fem-net \
    --to=s-beyer@gmx.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).