From: "Stephen R. van den Berg" <srb@cuci.nl>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-daemon: Simplify child management and associated logging by
Date: Wed, 13 Aug 2008 10:23:42 +0200 [thread overview]
Message-ID: <20080813082342.GC12628@cuci.nl> (raw)
In-Reply-To: <20080812225642.GA15265@cuci.nl>
Stephen R. van den Berg wrote:
>Junio C Hamano wrote:
>> - Taking advantage of poll() getting interrupted by SIGCHLD, so that you
>> do not have to do anything in the signal handler, is so obvious that I
>> am actually ashamed of not having to think of it the last time we
>> touched this code. Is there a poll() that does not return EINTR but
>> just call the handler and restart after that as if nothing has
>> happened, I have to wonder...
>Only if the signal is set to SIG_IGN on all systems I worked with since
>1987.
And even if it doesn't get interrupted and restarts, it means that it
merely leaves some zombies uncollected until the next new connection to
the daemon; nothing to get worried about.
--
Sincerely,
Stephen R. van den Berg.
"And now for something *completely* different!"
next prev parent reply other threads:[~2008-08-13 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 19:36 [PATCH] git-daemon: SysV needs the signal handler reinstated Stephen R. van den Berg
2008-08-12 21:25 ` [PATCH] git-daemon: Simplify child management and associated logging by Stephen R. van den Berg
2008-08-12 22:05 ` Junio C Hamano
2008-08-12 22:56 ` Stephen R. van den Berg
2008-08-12 23:52 ` Stephen R. van den Berg
2008-08-13 0:03 ` Stephen R. van den Berg
2008-08-13 0:07 ` Marcus Griep
2008-08-13 0:20 ` Junio C Hamano
2008-08-13 7:36 ` Stephen R. van den Berg
2008-08-13 8:23 ` Stephen R. van den Berg [this message]
2008-08-13 19:28 ` Junio C Hamano
2008-08-12 22:32 ` Alex Riesen
2008-08-12 23:12 ` Stephen R. van den Berg
2008-08-13 6:20 ` Alex Riesen
2008-08-13 7:21 ` Stephen R. van den Berg
2008-08-13 6:41 ` Andreas Ericsson
2008-08-13 7:18 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813082342.GC12628@cuci.nl \
--to=srb@cuci.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox