From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Tor Arne Vestbø" <torarnv@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml
Date: Thu, 14 Aug 2008 07:47:35 +0200 [thread overview]
Message-ID: <200808140747.35753.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <48A3310A.8080306@gmail.com>
onsdagen den 13 augusti 2008 21.07.54 skrev Tor Arne Vestbø:
> The default toolbar is identified by the path 'Normal',
> and we use the default group, named by 'additions'.
>
> The menu entry was not used, and was causing an extra
> empty space in the menu bar.
So that's why. Thanks.
Please try to prefix the patch with EGIT (or JGIT for JGit-only patches)
so we won't waste the time of those on the list having no interesting in this implementation.
I forgot it a few times myself.
-- robin
next prev parent reply other threads:[~2008-08-14 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:07 [PATCH] Fix invalid menubar and toolbar entries in plugin.xml Tor Arne Vestbø
2008-08-14 5:47 ` Robin Rosenberg [this message]
2008-08-14 17:42 ` [EGIT PATCH] " Robin Rosenberg
2008-08-14 19:13 ` Tor Arne Vestbø
2008-08-14 20:42 ` Robin Rosenberg
2008-08-14 20:45 ` [EGIT PATCH] Hide the Git menu and toolbars by default and fix the path of the Git menu Robin Rosenberg
2008-08-14 21:43 ` [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml Tor Arne Vestbø
2008-08-14 22:07 ` [EGIT PATCH v2] " Tor Arne Vestbø
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808140747.35753.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=torarnv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).