Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml

[Robin Rosenberg <robin.rosenberg.lists@dewire.com>]

torsdagen den 14 augusti 2008 21.13.51 skrev Tor Arne Vestbø:
> Robin Rosenberg wrote:
> >>> The menu entry was not used, and was causing an extra
> >>> empty space in the menu bar.
> > 
> > When I applied this patch the Git menu disappeared. (3.3)
> 
> Ah, I see. It appears the menu was used, but because it had the wrong
> path ('org.spearce.egit.ui.gitmenu' instead of 'additions') the four 
> entries did not show up in 3.4. 
That's our first 3.4 incompatibilty.

> Either way I suggest the patch is still valid, because it removes
> the Git menu from the menu bar. This is consistent with what other 
But I don't want it removed... , but I can consider hiding the git actions by default.

> platform plugins do, ie. not populating the main menu bar with plugin
Lots of plugins provide both menus and toolsbars so there is no inconsistence
with Git doing it. 

> specific entries, but instead using sub menus, context menus and views.
You can have it all. Eclipse is good at it. Anywhere there is a customizeable
context menu now you'll get a number of actions for RevObject's like the reset
etc actions. If you add, say a refs view with RevObjects in it you'd get the
contextg menues there too.

> In the long run we should probably also move the global toolbar entries
No. 

> to the synchronize view, when I get the chance to look at implementing 
> that. 

It is not clear, I think, what the synchronize view would look like to be an effective
git gui, but if we toss ideas around we might come to some conclusions/agreements.

> 
> Tor Arne
> 

-- robin