From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Tor Arne Vestbø" <torarnv@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Add some new icons, and apply them where appropriate
Date: Fri, 15 Aug 2008 00:02:40 +0200 [thread overview]
Message-ID: <200808150002.40762.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <48A33C8E.6050008@gmail.com>
onsdagen den 13 augusti 2008 21.57.02 skrev Tor Arne Vestbø:
> These icons are based on look of the existing CVS and
> SVN plugins, only with a Git branding (gray, red, green).
>
> Having the same look and feel as the other team plugins
> will probably help us in being distributed as part of
> the Eclipse platform.
>
> Signed-off-by: Tor Arne Vestbø <torarnv@gmail.com>
Looks nice, but please remove the icons that are not actually used from the
patch. I also wonder also whether the sharing icon should have a network-like
symbol. Connecting a project to a git repo involves no networking unlike
most other SCMs.
Welcome to the project, btw!
-- robin
next prev parent reply other threads:[~2008-08-14 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:57 [PATCH] Add some new icons, and apply them where appropriate Tor Arne Vestbø
2008-08-14 22:02 ` Robin Rosenberg [this message]
2008-08-14 22:52 ` [EGIT PATCH] " Tor Arne Vestbø
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808150002.40762.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=torarnv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).